fix: prefund num_wallets from base_mnemonic for non-persistent run#61
Open
mmsqe wants to merge 4 commits intoskip-mev:mainfrom
Open
fix: prefund num_wallets from base_mnemonic for non-persistent run#61mmsqe wants to merge 4 commits intoskip-mev:mainfrom
mmsqe wants to merge 4 commits intoskip-mev:mainfrom
Conversation
…istent run prefund derived num_wallets of wallets (n > 0) from base_mnemonic for interval/block runs
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 16. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to avoid insufficient funds error when sender selection rotates when only prefund wallet[0] at genesis based on base_mnemonic
Note
Medium Risk
Changes transaction funding and sender selection logic in the Ethereum loadtest runner, which can affect nonce usage and on-chain transfers during tests. Risk is moderate due to new prefunding transactions and altered sender rotation behavior, but scope is limited to loadtest execution.
Overview
Prevents finite (interval/block-bounded) Ethereum loadtests from failing when sender rotation reaches unfunded derived wallets by pre-funding zero-balance wallets from
wallets[0]duringNewRunner.Updates load generation so contract deployments always use
wallets[0](without advancing the sender distribution), while all other messages usetxFactory.GetNextSender()instead of random wallet selection; also defaultsspec.InitialWalletsto1when unset. Dependency bumps ingo.mod/go.sumupdatebytedance/sonicand related indirect modules.Written by Cursor Bugbot for commit 0f98b2c. This will update automatically on new commits. Configure here.