Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removed the vestigial
XCSkipTest.swiftfiles that are auto-generated as of skiptools/skipstone#210.It also puts back the manual insertion of the test runner which had been removed in 92cb15d:
For some reason, without adding them manually, all the Firebase tests run against Robolectric or an emulator fail with
java.lang.IllegalStateException: No instrumentation registered! Must run under a registering instrumentation.:I don't know why this affects Firebase and apparently none of the other Skip packages, but this workaround seem to fix it for the time being.