Apply aspectRatio to AsyncImage placeholder#321
Merged
marcprux merged 1 commit intoskiptools:mainfrom Feb 6, 2026
Merged
Conversation
4 tasks
dfabulich
force-pushed
the
async-image-placeholder-aspect-ratio
branch
from
a1dd385 to
21c05c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #320 reproduced in skiptools/skipapp-showcase#59
The layout still doesn't perfectly match iOS, and I guess that's a separate bug, but this PR is definitely fixing something, for now.
Specifically, I'm unclear why the layout is so different between the "No URL" and the "Failed URL" case. I think the answer is that
coil3.compose.SubcomposeAsyncImageis doing some layout trickery of its own.iOS
Android on skip-ui 1.47.0
After applying #321
Skip Pull Request Checklist:
swift test