Bug fix: On Android allowsHitTesting(false) consumes touches#353
Open
tifroz wants to merge 3 commits intoskiptools:mainfrom
Open
Bug fix: On Android allowsHitTesting(false) consumes touches#353tifroz wants to merge 3 commits intoskiptools:mainfrom
allowsHitTesting(false) consumes touches#353tifroz wants to merge 3 commits intoskiptools:mainfrom
Conversation
…ouches to pass through" This reverts commit ee59fd3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.clickable(enabled: false, onClick: {})disables the view handlers for touch events but still consumes touches, breaking the iOS contract (whereallowsHitTesting(false)should allow touches to reach the lower layers)I changed
allowsHitTesting()to be a no-op on android, and added a unit-testtestAllowsHitTestingFalseOverlayPassesTapThroughthat must run on a real device/simulator. A no-op is not perfect, but better than doing the opposite it should be doing.I verified that the new test
I think SkiFuseUI simply proxies the call to SkipUI's
allowsHitTesting()? If so this fix should apply to SkipFuseUI as wellSkip Pull Request Checklist:
swift test