More alert playgrounds, native alert playgrounds#63
Open
dfabulich wants to merge 2 commits intoskiptools:mainfrom
Open
More alert playgrounds, native alert playgrounds#63dfabulich wants to merge 2 commits intoskiptools:mainfrom
dfabulich wants to merge 2 commits intoskiptools:mainfrom
Conversation
7 tasks
marcprux
requested changes
Mar 7, 2026
| data = 1 | ||
| } else { | ||
| data = data! + 1 | ||
| #if SKIP |
Member
There was a problem hiding this comment.
Why is this in an #if SKIP block?
| // error = nil | ||
| // } | ||
| // } | ||
| #if SKIP |
Member
There was a problem hiding this comment.
Was this SKIP block just for your own Compose experimentation? Can we remove it?
Contributor
Author
There was a problem hiding this comment.
These display the original Material 3 AlertDialog dialogs, which were the basis of my work in skiptools/skip-ui#336.
It seems plausible to me that we'd do some regression testing on this in the future (e.g. Material 4 or something).
I think it's good to leave these in, but I'll remove them if you insist…?
dfabulich
force-pushed
the
native-alert-playgrounds
branch
from
240723a to
41ce29f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a playground for a very long alert, for long button titles, and added an Android-only block showing native
AlertDialogs(for comparison)Skip Pull Request Checklist:
swift test