Added support for .strings and .stringsdict files#215
Added support for .strings and .stringsdict files#215fhasse95 wants to merge 5 commits intoskiptools:mainfrom
Conversation
|
We should have already been copying raw As you suspect, though, we don't yet have any support for handing pluralizations, so we don't actually do anything with the generated It would be a fantastic feature to have, but I've never had enough time to work on it. If you're interested in diving deeper, it would make a great contribution! |
|
Hi @marcprux, Thanks a lot for the quick feedback! You’re absolutely right. It turns out I had an error in my own package configuration where the localized strings were located. After switching back from my local skipstone plugin to the official 1.7.7 release, I can confirm that the Regarding the pluralization support: Thank you so much for the detailed context! It sounds indeed quite challenging but I’ll definitely dive deeper into this and look into how Best regards, |
|
Closed in favor of skiptools/skip-foundation#102, I presume. |
This PR improves support for localized strings by also copying the
*.stringsand*.stringsdictfiles to the resources.This is particularly useful for projects that haven’t yet adopted to the
*.xcstringsformat. For instance, I still prefer using the*.lprojstructure for open-source repositories as they are much easier to review in Git diffs and allow contributors to assist with translations without needing specialized tools or dealing with the complex JSON structure of*.xcstrings.During the adjustment, the following question also came into my mind:
As I’ve noticed, the plural variants from the
*.xcstringsfiles are already converted internally into*.stringsdictfiles. However, according to the documentation, these are currently not supported. Is this still planned, or is it technically not possible? I’ve already looked into the Skip Foundation to see how the mapping of localized strings currently works, but I haven’t found a solution on how to support it yet. But maybe I just don't have the necessary background knowledge.Looking forward to your response! 😊
Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.
Skip Pull Request Checklist:
swift test