Avoid iterator allocation for prepared ExecuteNonQuery#1
Draft
skuirrels wants to merge 1 commit into
Draft
Conversation
Owner
Author
|
This is stacked on Giorgi#340 and should only be merged after Giorgi#340 has been merged. I have therefore left in draft state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on Giorgi#340 so the diff stays focused on this follow-up.
Problem
Prepared
ExecuteNonQuery()still goes through anIEnumerableiterator even though a reusable prepared command contains one statement. That adds a fixed 112-byte allocation to every execution.Solution
Execute that single prepared result directly, while keeping the existing iterator path for readers, unprepared commands, and multi-statement commands. Prepared-statement lifecycle and deferred disposal still use the same shared bookkeeping.
Benchmark
Median of 7 runs after warmup, 20,000 executions per run:
The remaining 120 bytes come from parameter-value wrappers and are outside this change. Timing varied within noise; the allocation reduction was stable.
Tests
DuckDBCommandTests: 13 passed