Skip to content

Fix race condition for the initial color using selectorPositionInitia… #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skydoves merged 1 commit into from
Jan 10, 2026
Merged

Fix race condition for the initial color using selectorPositionInitia… #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions colorpickerview/src/main/java/com/skydoves/colorpickerview/sliders/AbstractSlider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ abstract class AbstractSlider extends FrameLayout {
protected int color = Color.WHITE;
protected ImageView selector;
protected String preferenceName;
protected boolean selectorPositionInitialized = false;

public AbstractSlider(Context context) {
super(context);
Expand Down Expand Up @@ -206,6 +207,7 @@ public void setSelectorPosition(@FloatRange(from = 0.0, to = 1.0) float selector
float x = (getWidth() * selectorPosition) - getSelectorSize() - getBorderHalfSize();
selectedX = (int) getBoundaryX(x);
selector.setX(selectedX);
selectorPositionInitialized = true;
}

public void setSelectorByHalfSelectorPosition(
Expand All @@ -214,6 +216,7 @@ public void setSelectorByHalfSelectorPosition(
float x = (getWidth() * selectorPosition) - (getSelectorSize() * 0.5f) - getBorderHalfSize();
selectedX = (int) getBoundaryX(x);
selector.setX(selectedX);
selectorPositionInitialized = true;
}

private float getBoundaryX(float x) {
Expand Down
6 changes: 6 additions & 0 deletions colorpickerview/src/main/java/com/skydoves/colorpickerview/sliders/AlphaSlideBar.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,12 @@ public void updatePaint(Paint colorPaint) {

@Override
public void onInflateFinished() {
// Skip default positioning if the selector position was already set
// (e.g., via setInitialColor before layout completed)
if (selectorPositionInitialized) {
return;
}

int defaultPosition = getWidth() - selector.getWidth();
if (getPreferenceName() != null) {
updateSelectorX(
Expand Down
6 changes: 6 additions & 0 deletions colorpickerview/src/main/java/com/skydoves/colorpickerview/sliders/BrightnessSlideBar.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,12 @@ protected void updatePaint(Paint colorPaint) {
public void onInflateFinished() {
selector.post(
() -> {
// Skip default positioning if the selector position was already set
// (e.g., via setInitialColor before layout completed)
if (selectorPositionInitialized) {
return;
}

int defaultPosition = getWidth() - selector.getWidth();

if (getPreferenceName() != null) {
Expand Down