Merged
Conversation
- Update error messages and logs according to changes - Update detokenize sample to work with new changes
…ction-type-for-each-token-in-detokenize-method SK-1875 Add separate redaction types for tokens in Detokenize
- Add requestId for detokenize failure responses when continueOnError is true - Add requestId for insert failure responses when continueOnError is true
SK-1893 Update README for v2
…n-response-for-continue-on-error-failure-cases SK-1890 Add request Ids in response for continue on error failures
…ors-in-connections SK-1900 Improve debugging errors in connections
amith-skyflow
approved these changes
Apr 1, 2025
saileshwar-skyflow
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges the feedback items for Java SDK v2 in
v2branch.Why
Goal
v2branch.Testing