SK-2177 reveal composable element changes#606
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
| options.label = element.label; | ||
| options.skyflowID = element.skyflowID; |
There was a problem hiding this comment.
missing null checks
| this.#tempElements.elementName = isSingleElementAPI | ||
| ? elements[0].elementName | ||
| : `${FRAME_ELEMENT}:group:${btoa(this.#tempElements)}`; |
There was a problem hiding this comment.
even though above is older but better to add null checks.
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
4 participants
Why