SK-2503: Add support for custom tokenUri#275
SK-2503: Add support for custom tokenUri#275saileshwar-skyflow merged 2 commits intorelease/26.1.5from
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
There was a problem hiding this comment.
Pull request overview
This PR adds support for custom token URIs to enable Bring Your Own Cloud (BYOC) integrations. The implementation allows users to specify a custom tokenUri option in credentials or token generation options, which overrides the default token endpoint.
Changes:
- Added
tokenUrias an optional field toPathCredentialsandStringCredentialsinterfaces - Implemented validation logic to ensure
tokenUriis a valid HTTPS URL when provided - Modified token generation functions to accept and use custom
tokenUrifrom options
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vault/config/credentials/index.ts | Added optional tokenUri field to credential interfaces |
| src/utils/validations/index.ts | Added validation logic for tokenUri in credential validation functions |
| src/utils/index.ts | Modified getToken to pass tokenUri to token generation functions |
| src/service-account/index.ts | Added tokenUri validation and override logic in token generation functions |
| src/error/codes/index.ts | Added INVALID_TOKEN_URI error code |
| src/error/messages/index.ts | Added error message for invalid token URI |
| test/utils/validations.test.js | Added comprehensive tests for tokenUri validation |
| test/service-account/token.test.js | Added tests for tokenUri override functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
3 participants
Why
Outcome