aadarsh-st/SK-2510-Fixed all the mentioned issue#279
aadarsh-st/SK-2510-Fixed all the mentioned issue#279aadarsh-st merged 3 commits intorelease/26.1.4from
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
aadarsh-st
requested review from
Devesh-Skyflow,
Copilot,
saileshwar-skyflow and
skyflow-bharti
There was a problem hiding this comment.
Pull request overview
This PR fixes multiple issues identified in ticket SK-2510, including a bug in URL parameter replacement, improvements to error handling for HTTP responses, and enhanced error messages for bearer token validation.
Changes:
- Fixed a bug in
fillUrlWithPathAndQueryParamswhere only the first path parameter was being replaced - Enhanced error handling in connection controller to properly consume response bodies and prevent connection leaks
- Improved bearer token error messages to clarify that tokens may be invalid or expired
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/utils/index.ts | Fixed variable reference bug where url was used instead of filledUrl in the replace operation |
| test/vault/utils/utils.test.js | Updated test expectation to reflect correct behavior of replacing all path parameters |
| src/vault/controller/connections/index.ts | Enhanced error response handling with proper JSON/text parsing and body consumption |
| src/error/messages/index.ts | Improved error messages to indicate bearer tokens may be invalid or expired |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 participants
Fixed following issues:
Path parameters are not concatenated in the fillUrlWithPathAndQueryParams function.
Readers and HTTP connections are not closed after receiving responses, which may lead to resource leaks.
Enhance the error message for invalid bearer token.