SK-2536: Fix different content-types in request and respones in invoke connection interface#281
Merged
saileshwar-skyflow merged 3 commits intorelease/26.1.4from Feb 5, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the handling of different Content-Type headers in requests and responses within the invoke connection interface. The changes ensure proper content type detection, request body formatting, and response parsing for various formats including JSON, XML, URL-encoded, multipart form data, HTML, and plain text.
Changes:
- Added support for multiple content types (XML, HTML, multipart/form-data) in both request and response handling
- Implemented case-insensitive content-type header matching
- Added
objectToXMLutility function to convert JavaScript objects to XML format - Enhanced response parsing logic to handle different content types appropriately
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/vault/utils/utils.test.js | Added comprehensive test coverage for the new objectToXML utility function |
| test/vault/controller/connection.test.js | Expanded test suite to cover request body building and response parsing for various content types |
| src/vault/controller/connections/index.ts | Refactored connection controller to handle multiple content types in requests and responses with case-insensitive header matching |
| src/utils/index.ts | Added objectToXML utility function and new content type constants |
| src/error/messages/index.ts | Added error message for invalid XML format |
| src/error/codes/index.ts | Added error code for invalid XML format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
skyflow-bharti
approved these changes
Feb 5, 2026
aadarsh-st
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Outcome