Skip to content

SK-2536: Fix different content-types in request and respones in invoke connection interface#281

Merged
saileshwar-skyflow merged 3 commits intorelease/26.1.4from
saileshwar/SK-2536-verify-diff-req-res-content-type-invoke-connection
Feb 5, 2026
Merged

SK-2536: Fix different content-types in request and respones in invoke connection interface#281
saileshwar-skyflow merged 3 commits intorelease/26.1.4from
saileshwar/SK-2536-verify-diff-req-res-content-type-invoke-connection

Conversation

@saileshwar-skyflow
Copy link
Collaborator

Why

  • Different Content-Type headers are not handled correctly in requests and responses within the invoke connection interface.

Outcome

  • Proper handling of different Content-Type headers in both requests and responses.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the handling of different Content-Type headers in requests and responses within the invoke connection interface. The changes ensure proper content type detection, request body formatting, and response parsing for various formats including JSON, XML, URL-encoded, multipart form data, HTML, and plain text.

Changes:

  • Added support for multiple content types (XML, HTML, multipart/form-data) in both request and response handling
  • Implemented case-insensitive content-type header matching
  • Added objectToXML utility function to convert JavaScript objects to XML format
  • Enhanced response parsing logic to handle different content types appropriately

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/vault/utils/utils.test.js Added comprehensive test coverage for the new objectToXML utility function
test/vault/controller/connection.test.js Expanded test suite to cover request body building and response parsing for various content types
src/vault/controller/connections/index.ts Refactored connection controller to handle multiple content types in requests and responses with case-insensitive header matching
src/utils/index.ts Added objectToXML utility function and new content type constants
src/error/messages/index.ts Added error message for invalid XML format
src/error/codes/index.ts Added error code for invalid XML format

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@saileshwar-skyflow saileshwar-skyflow merged commit c288801 into release/26.1.4 Feb 5, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants