SK-2522: Fix Python SDK v2 issues reported in Bug Bash#231
Merged
saileshwar-skyflow merged 5 commits intorelease/26.1.4from Feb 5, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses multiple issues in the Python SDK v2 identified during the Bug Bash, focusing on error handling, validation logic, and connection invocation functionality.
Changes:
- Fixed error handling in connection invocation and response parsing to properly handle non-JSON content
- Corrected validation logic for wait time, credentials, and request parameters
- Added comprehensive test coverage for new error scenarios and edge cases
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/vault/controller/test__connection.py | Expanded test coverage for connection invocation with additional test cases for credentials, error handling, and metadata headers |
| tests/vault/client/test__client.py | Added tests for bearer token expiration, reuse, and regeneration scenarios |
| tests/utils/validations/test__validations.py | Updated expired token test expectation and added boundary tests for wait time validation |
| tests/utils/test__utils.py | Added extensive tests for response parsing, content type handling, error scenarios, and utility functions |
| skyflow/vault/controller/_connections.py | Reordered connection invocation logic to resolve credentials before constructing requests |
| skyflow/vault/client/client.py | Fixed error type for expired token from SyntaxError to SkyflowError |
| skyflow/utils/validations/_validations.py | Fixed validation logic for wait time, credentials, and get request; updated error messages |
| skyflow/utils/enums/content_types.py | Added HTML content type enum |
| skyflow/utils/_utils.py | Enhanced content type handling, fixed response parsing for non-JSON content, improved error handling |
| skyflow/utils/_skyflow_messages.py | Updated error messages for consistency and added new EXPIRED_BEARER_TOKEN message |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…gs-identified-in-bug-bash
skyflow-bharti
approved these changes
Feb 5, 2026
aadarsh-st
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Issues related to Python SDK v2 were identified during the Bug Bash.
Fixing them is required to improve reliability and align behavior with expected standards.
Outcome
Fixed all Python SDK v2 issues identified in the Bug Bash document.
Improved error handling and overall stability of the SDK.