Skip to content

SK-2173 revert unformatted card no insertion to vault #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raushan-skyflow merged 1 commit into from
Jul 18, 2025
Merged

SK-2173 revert unformatted card no insertion to vault #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 1 addition & 29 deletions __tests__/core-utils/collect.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
Copyright (c) 2022 Skyflow, Inc.
*/
import { tokenize, getElementValueToInsert } from '../../src/core-utils/collect';
import { tokenize } from '../../src/core-utils/collect';
import CollectElement from '../../src/core/CollectElement';
import Skyflow from '../../src/core/Skyflow';
import { ElementType, Env, LogLevel } from '../../src/utils/constants';
Expand Down Expand Up @@ -525,31 +525,3 @@ describe('test collect utils class', () => {
});

});

describe('getVaultInsertValue', () => {
class MockCollectElement {
constructor(type, value) {
this.type = type;
this.value = value;
}
getClientState() {
return { elementType: this.type };
}
getUnformattedValue() {
return this.value.replace(/[\s-]/g, '');
}
getInternalState() {
return { value: this.value };
}
}

test('returns unformatted value for CARD_NUMBER', () => {
const element = new MockCollectElement(ElementType.CARD_NUMBER, '4111 1111 1111 1111');
expect(getElementValueToInsert(element)).toBe('4111111111111111');
});

test('returns value as is for non-CARD_NUMBER', () => {
const element = new MockCollectElement(ElementType.CVV, '123');
expect(getElementValueToInsert(element)).toBe('123');
});
});
24 changes: 0 additions & 24 deletions __tests__/core/collectElement.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,30 +524,6 @@ describe('test Collect Element class', () => {
);
});

it('should remove spaces from value', () => {
const elementInput = {
table: 'cards',
column: 'number',
type: ElementType.CARD_NUMBER,
containerType: ContainerType.COLLECT,
};
const collectElement = new CollectElement(elementInput, {}, context);
collectElement.updateValue('4111 1111 1111 1111');
expect(collectElement.getUnformattedValue()).toBe('4111111111111111');
});

it('should remove hyphens from value', () => {
const elementInput = {
table: 'cards',
column: 'number',
type: ElementType.CARD_NUMBER,
containerType: ContainerType.COLLECT,
};
const collectElement = new CollectElement(elementInput, {}, context);
collectElement.updateValue('4111-1111-1111-1111');
expect(collectElement.getUnformattedValue()).toBe('4111111111111111');
});

it('test format option in card number element', () => {
const formatTestCases = [
// Test different valid formats for the card number
Expand Down
8 changes: 4 additions & 4 deletions src/core-utils/collect/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,14 +229,14 @@ export const tokenize = (
set(
elementsUpdateData[skyflowID],
column,
getElementValueToInsert(currentElement),
currentElement.getInternalState().value,
);
} else {
elementsUpdateData[skyflowID] = {};
set(
elementsUpdateData[skyflowID],
column,
getElementValueToInsert(currentElement),
currentElement.getInternalState().value,
);
set(
elementsUpdateData[skyflowID],
Expand All @@ -246,10 +246,10 @@ export const tokenize = (
}
}
else if (elementsData[table]) {
set(elementsData[table], column, getElementValueToInsert(currentElement));
set(elementsData[table], column, currentElement.getInternalState().value);
} else {
elementsData[table] = {};
set(elementsData[table], column, getElementValueToInsert(currentElement));
set(elementsData[table], column, currentElement.getInternalState().value);
}
});

Expand Down