Fix Facebook login frozen/unresponsive in WebView#20
Merged
MisterGatto merged 1 commit intoskyprotocol:osp-masterfrom Apr 5, 2026
Merged
Fix Facebook login frozen/unresponsive in WebView#20MisterGatto merged 1 commit intoskyprotocol:osp-masterfrom
MisterGatto merged 1 commit intoskyprotocol:osp-masterfrom
Conversation
The Facebook OAuth page rendered but was completely uninteractive. Inputs couldn't be tapped or typed into, the content appeared behind an unskippable grey barrier. Root cause: WebLogin was missing several WebSettings that the original Sky OAuth implementation provides. Facebook's login page requires DOM storage, web database support, and third-party cookies to function. Without these, the page paints but its JavaScript cannot operate. These are local WebView settings - they don't phone home, add tracking, or include any SDK. Added the missing settings to match the original implementation: - setDomStorageEnabled (localStorage/sessionStorage for FB scripts) - setDatabaseEnabled (web database support) - setUseWideViewPort (proper viewport handling) - setAcceptThirdPartyCookies (required for cross-domain OAuth flow)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Facebook login frozen/unresponsive in WebView
Problem
The Facebook OAuth page rendered in the WebView but was completely uninteractive. Inputs couldn't be tapped or typed into, the content appeared behind an unskippable barrier. Other providers (Steam, Nintendo) were unaffected.
Root cause
WebLogin.java was missing several settings that the original Sky OAuth implementation provides. Facebook's login page requires DOM storage, web database support, and third-party cookies to function. Without these, the page paints but its JavaScript cannot operate.
Fix
Added the missing settings to match the original implementation:
These are local WebView settings - they don't phone home, add tracking, or include any SDK.
Before
After