Fix duplicate mod checkboxes, add i18n (ru, de)#21
Merged
MisterGatto merged 2 commits intoskyprotocol:osp-masterfrom Apr 8, 2026
Merged
Fix duplicate mod checkboxes, add i18n (ru, de)#21MisterGatto merged 2 commits intoskyprotocol:osp-masterfrom
MisterGatto merged 2 commits intoskyprotocol:osp-masterfrom
Conversation
Clear the userLibs vector in settle() before mods are re-registered, preventing stale entries from accumulating across game launches.
- Migrate hardcoded strings from layouts and Java code to string resources - Mark non-translatable strings (paths, format strings, brand names) - Add Russian (values-ru) and German (values-de) translations - Add locales_config.xml for per-app language switching on Android 13+ - Fix typos: "Annulla" -> "Cancel", "NATRUAL" -> "NATURAL"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Bug fix: Duplicate mod checkboxes in Canvas Menu
Problem
Launching the game multiple times without the process dying causes duplicate checkboxes for the same mod in the ImGui Canvas Menu:
How it happens
When the user swipes Canvas from recents, Android may keep the process alive, particularly if the LogcatMonitorService foreground service is running, or due to normal process caching. The native library and its static state survive. If the user then reopens Canvas, manages mods (delete/re-add), and launches the game again,
onModLibrarypushes new entries into theuserLibsvector alongside stale ones from the previous session.The
/proc/self/mapsdeduplication inElfLoaderis also bypassed in this scenario, because a deleted-then-re-added.sofile appears as"mod.so (deleted)"in the maps, which doesn't match the new filename.Steps to reproduce (deterministic, via adb)
adb shell am start -n git.artdeell.skymodloader/.elfmod.ModManagerActivityFix
Added
Canvas::userLibs.clear()at the top ofsettle(), which runs once per game launch before any mods are registered. This ensures a clean slate regardless of prior process state.2. Feature: i18n support (Russian, German)
What changed
strings.xmltranslatable="false"locales_config.xmlfor per-app language switching on Android 13+Testing
./gradlew assembleDebug)