Skip to content

chore(paginator): low contrast + selected state#3289

Draft
michal-sanoma wants to merge 2 commits into
mainfrom
fix/2708_paginator_low_contrast
Draft

chore(paginator): low contrast + selected state#3289
michal-sanoma wants to merge 2 commits into
mainfrom
fix/2708_paginator_low_contrast

Conversation

@michal-sanoma
Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings May 8, 2026 18:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

🕸 Website preview

You can view a preview here (commit 9a7ef93ceb713d6da1ed5233faa37406015ad8c7).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

🕸 Storybook preview

You can view a preview here (commit 9a7ef93ceb713d6da1ed5233faa37406015ad8c7).

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates paginator page buttons to use a lower-contrast idle/hover/active background treatment and a clearer “current page” selected style, enabled by new theming hooks on sl-button.

Changes:

  • Added --sl-button-* CSS custom properties to sl-button to allow external control of background mix and text color.
  • Updated paginator page buttons (.page) to use the new button-level theming variables for neutral interactive states.
  • Updated paginator current page styling (.current) to use bold background and on-bold foreground tokens.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/components/paginator/src/paginator.scss Applies new sl-button theming variables for page and current-page states.
packages/components/button/src/button.scss Introduces --sl-button-bg-color, --sl-button-bg-mix-color, --sl-button-bg-opacity, and --sl-button-color overrides in button styling.

Comment on lines +66 to 70
--sl-button-bg-color: var(--sl-color-background-primary-bold);
--sl-button-bg-mix-color: var(--sl-color-background-primary-interactive-bold);
--sl-button-bg-opacity: var(--sl-opacity-interactive-plain-idle);
--sl-button-color: var(--sl-color-foreground-primary-onBold);

Comment on lines +81 to +82
--sl-button-bg-color: var(--sl-color-background-primary-bold);
--sl-button-bg-mix-color: var(--sl-color-background-primary-interactive-bold);
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 19, 2026

⚠️ No Changeset found

Latest commit: 9a7ef93

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package "@sl-design-system/grid" depends on the ignored package "@sl-design-system/example-data", but "@sl-design-system/grid" is not being ignored. Please add "@sl-design-system/grid" to the `ignore` option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants