feat: add 'features.agent_view' property#74
Merged
Conversation
Mirrors the canonical agent_view definition from webapp's manifest schema. Sibling of assistant_view; supports agent_description, suggested_prompts (max 4), and actions. Adds local-schema test coverage so edits to the versioned schema files are validated before release. Existing tests run through the GitHub-pinned schema and would not catch local changes.
2 tasks
Reverts the local-schema tests added in the previous commit so this PR matches the existing schema-only feature pattern (mcp_servers, is_mcp_enabled, optional scopes). Coverage will land in a separate PR that refactors the test suite to run every case against both the hosted router schema and the local versioned files.
3 tasks
mwbrooks
commented
Jun 19, 2026
mwbrooks
left a comment
Member
Author
There was a problem hiding this comment.
Notes for the kind reviewers 🙇🏻
| } | ||
| } | ||
| }, | ||
| "app-manifests.v1.features.agent_view": { |
Member
Author
There was a problem hiding this comment.
note: added after the assistant_view property. These properties don't appear to be alphabetically ordered.
Comment on lines
+504
to
+506
| }, | ||
| "agent_view": { | ||
| "$ref": "#/definitions/app-manifests.v1.features.agent_view" |
Member
Author
There was a problem hiding this comment.
note: Added after the assistant_view because these properties don't appear to be organized alphabetically.
zimeg
approved these changes
Jun 19, 2026
zimeg
left a comment
Member
There was a problem hiding this comment.
@mwbrooks Super good! I'm marking this "approved" as testing continues.
🧮 The notes of alphabetics is appreciated too. I think that might be a topic we can visit in adjacent changes since I share question of how properties are meant to be ordered sometimes.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent_viewfeature property to both v1 and v2 manifest schemas.agent_description(max 300 chars),suggested_prompts(max 4 items,{title, message}), andactions({name, description}).Release notes
This change does not bump the schema version automatically- the next release would
v0.5.0.Test plan
./scripts/test.sh— existing tests pass against the hosted (v0.4.0) router schema./scripts/lint.sh— clean