Skip to content

feat: add 'features.agent_view' property#74

Merged
mwbrooks merged 2 commits into
mainfrom
mwbrooks-manifest-agent-view
Jun 20, 2026
Merged

feat: add 'features.agent_view' property#74
mwbrooks merged 2 commits into
mainfrom
mwbrooks-manifest-agent-view

Conversation

@mwbrooks

@mwbrooks mwbrooks commented Jun 19, 2026

Copy link
Copy Markdown
Member

Summary

Release notes

This change does not bump the schema version automatically- the next release would v0.5.0.

Test plan

Mirrors the canonical agent_view definition from webapp's manifest
schema. Sibling of assistant_view; supports agent_description,
suggested_prompts (max 4), and actions.

Adds local-schema test coverage so edits to the versioned schema files
are validated before release. Existing tests run through the
GitHub-pinned schema and would not catch local changes.
Reverts the local-schema tests added in the previous commit so this PR
matches the existing schema-only feature pattern (mcp_servers,
is_mcp_enabled, optional scopes). Coverage will land in a separate PR
that refactors the test suite to run every case against both the hosted
router schema and the local versioned files.
@mwbrooks mwbrooks changed the title feat: add agent_view feature property feat: add 'features.agent_view' property Jun 19, 2026
@mwbrooks mwbrooks self-assigned this Jun 19, 2026
@mwbrooks mwbrooks added enhancement New feature or request semver:minor labels Jun 19, 2026

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes for the kind reviewers 🙇🏻

}
}
},
"app-manifests.v1.features.agent_view": {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: added after the assistant_view property. These properties don't appear to be alphabetically ordered.

Comment on lines +504 to +506
},
"agent_view": {
"$ref": "#/definitions/app-manifests.v1.features.agent_view"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Added after the assistant_view because these properties don't appear to be organized alphabetically.

@mwbrooks mwbrooks marked this pull request as ready for review June 19, 2026 04:22

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks Super good! I'm marking this "approved" as testing continues.

🧮 The notes of alphabetics is appreciated too. I think that might be a topic we can visit in adjacent changes since I share question of how properties are meant to be ordered sometimes.

@mwbrooks

Copy link
Copy Markdown
Member Author

@zimeg Thanks for the review and sounds good about a follow-up on alphabetical ordering. We may want to land that after we have local testing enabled in #75.

@mwbrooks mwbrooks merged commit a936b12 into main Jun 20, 2026
4 checks passed
@mwbrooks mwbrooks deleted the mwbrooks-manifest-agent-view branch June 20, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request semver:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants