Skip to content

chore: modernize prod server integration tests#2590

Merged
WilliamBergamin merged 7 commits into
mainfrom
bring-up-to-date-the-prod-server-integration-tests
May 7, 2026
Merged

chore: modernize prod server integration tests#2590
WilliamBergamin merged 7 commits into
mainfrom
bring-up-to-date-the-prod-server-integration-tests

Conversation

@WilliamBergamin
Copy link
Copy Markdown
Contributor

Summary

  • Migrate test framework from Mocha/Chai to Node.js built-in test runner (node:test + node:assert/strict)
  • Convert to ESM ("type": "module") and remove legacy dependencies (winston, chai, mocha)
  • Use file: references to local @slack/web-api and @slack/socket-mode packages instead of shell-based linking scripts
  • Add comprehensive documentation: .env.sample, app manifest.json with setup instructions, and an expanded README
  • Add a custom logger utility to replace winston

Requirements

@WilliamBergamin WilliamBergamin requested a review from zimeg May 7, 2026 20:12
@WilliamBergamin WilliamBergamin self-assigned this May 7, 2026
@WilliamBergamin WilliamBergamin requested a review from a team as a code owner May 7, 2026 20:13
@WilliamBergamin WilliamBergamin added the tests M-T: Testing work only label May 7, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 7, 2026

⚠️ No Changeset found

Latest commit: 520effd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.52%. Comparing base (3411de3) to head (520effd).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2590   +/-   ##
=======================================
  Coverage   87.52%   87.52%           
=======================================
  Files          62       62           
  Lines       10228    10228           
  Branches      418      418           
=======================================
  Hits         8952     8952           
  Misses       1254     1254           
  Partials       22       22           
Flag Coverage Δ
cli-hooks 87.52% <ø> (ø)
cli-test 87.52% <ø> (ø)
logger 87.52% <ø> (ø)
oauth 87.52% <ø> (ø)
socket-mode 87.52% <ø> (ø)
web-api 87.52% <ø> (ø)
webhook 87.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilliamBergamin It's nice when things get better this is nice! 🧪 ✨

@WilliamBergamin WilliamBergamin merged commit 963f9b0 into main May 7, 2026
12 checks passed
@WilliamBergamin WilliamBergamin deleted the bring-up-to-date-the-prod-server-integration-tests branch May 7, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests M-T: Testing work only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants