Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
==========================================
+ Coverage 65.06% 65.24% +0.17%
==========================================
Files 215 215
Lines 18179 18123 -56
==========================================
- Hits 11829 11824 -5
+ Misses 5254 5206 -48
+ Partials 1096 1093 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwbrooks
left a comment
There was a problem hiding this comment.
Comments for the patient reviewers 🙇🏻
| ### Formatting | ||
|
|
||
| Always run `gofmt -w` on changed Go files after making edits to ensure proper formatting. | ||
|
|
There was a problem hiding this comment.
note: Just adding this to scratch an itch where Claude fails to format files correctly.
| var appCreateSpinner *style.Spinner | ||
|
|
||
| const copyTemplate = "Copying" | ||
| const cloneTemplate = "Cloning" | ||
|
|
There was a problem hiding this comment.
note: Removing because the spinner was never started in the current code.
| case "on_app_create_template_default": | ||
| printAppCreateDefaultemplate(cmd, event) | ||
| case "on_app_create_template_custom": | ||
| printAppCreateCustomTemplate(cmd, event) |
There was a problem hiding this comment.
note: Neither of these events were ever called. This is why the spinner was never started.
| case "on_app_create_completion": | ||
| printProjectCreateCompletion(clients, cmd, event) |
There was a problem hiding this comment.
note: This event was correctly called, but the spinner was never started so any calls to stop it are ignored.
| // Notify listeners | ||
| log.Log("info", "on_app_create_template") |
There was a problem hiding this comment.
note: This event name doesn't exist 🤦🏻 It should have been on_app_create_template_[default|custom].
Changelog
Summary
This pull request is part 2 of removing internal/logger package and is focused on the the
createcommand.appCreateSpinneris removed because it was never usedTest Steps
Requirements