Skip to content

fix(python): output a warning for .venv activation errors#368

Open
mwbrooks wants to merge 1 commit intomainfrom
mwbrooks-venv-error-warning
Open

fix(python): output a warning for .venv activation errors#368
mwbrooks wants to merge 1 commit intomainfrom
mwbrooks-venv-error-warning

Conversation

@mwbrooks
Copy link
Member

@mwbrooks mwbrooks commented Mar 7, 2026

Changelog

Output a warning instead of an error when activating the Python virtual environment (.venv/) fails.

Summary

This pull request updates the Python virtual environment (.venv/) activation issues to be output as warnings.

Related to feedback: #347 (comment)

Requirements

@mwbrooks mwbrooks requested a review from a team as a code owner March 7, 2026 00:31
@codecov
Copy link

codecov bot commented Mar 7, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.08%. Comparing base (c449532) to head (ad9bc9e).

Files with missing lines Patch % Lines
internal/shared/clients.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
+ Coverage   65.06%   65.08%   +0.01%     
==========================================
  Files         215      215              
  Lines       18179    18179              
==========================================
+ Hits        11829    11832       +3     
- Misses       5254     5255       +1     
+ Partials     1096     1092       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwbrooks mwbrooks changed the title fix: surface venv activation errors as warnings fix(python): output a warning for .venv activation errors Mar 7, 2026
@mwbrooks mwbrooks self-assigned this Mar 7, 2026
@mwbrooks mwbrooks added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch Use on pull requests to describe the release version increment area:bolt-python Related to github.com/slackapi/bolt-python labels Mar 7, 2026
@mwbrooks mwbrooks added this to the Next Release milestone Mar 7, 2026
@mwbrooks mwbrooks added the changelog Use on updates to be included in the release notes label Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:bolt-python Related to github.com/slackapi/bolt-python bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented changelog Use on updates to be included in the release notes semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant