Add configurable daemon HTTP bind address (--bind / config bind)#103
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix daemon binding to allow 0.0.0.0
Add configurable daemon HTTP bind address (May 31, 2026
--bind / config bind)
albertwoo
requested changes
May 31, 2026
albertwoo
left a comment
Contributor
There was a problem hiding this comment.
Move the duplicate fn format_http_url to src\utils.rs.
Contributor
Author
Done in e62280c. I moved |
albertwoo
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daemon HTTP listener was effectively locked to loopback (
127.0.0.1), which prevented running it on0.0.0.0or other explicit interfaces. This change makes bind address configurable at runtime and in config, while preserving loopback as the default.CLI + config surface
--bind <addr>tooly daemon start.bind(default remains127.0.0.1).HTTP server binding behavior
127.0.0.1socket construction with parsedhttp_bind+http_port.Daemon status/summary output
E2E and supporting test utilities
start_daemon_http_with_bind(...)in shared e2e helpers.--bind 0.0.0.0starts successfully and serves HTTP requests.Docs alignment
--bind.# New runtime behavior oly daemon start --bind 0.0.0.0 --port 15443