Fix terminal reset, bulk-approve flash, and closed PR visibility#19
Merged
Conversation
- Give tea a duped stdout FD so autoupdater's FD-1 /dev/null redirect can't swallow alt-screen exit - Gate bulk-approve transition on all repo list fetches completing to stop mid-startup flicker - Hide CLOSED (non-merged) PRs unless they have new activity Closes #18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/dev/nullcan no longer swallow tea's alt-screen-exit sequences (no more needingresetbefore running prx)tryStartupTransition's bulk-approve entry on all repos' open/merged/tracked list fetches being complete — stops the fireworks/flicker when running across many reposState == "CLOSED"(closed-without-merge) PRs in the review list unless they have new activity; there's nothing to approve or react toCloses #18
Security implications of changes have been considered