feat(memify): add status endpoints for async runs#1
Open
slime-turing wants to merge 3 commits intomainfrom
Open
feat(memify): add status endpoints for async runs#1slime-turing wants to merge 3 commits intomainfrom
slime-turing wants to merge 3 commits intomainfrom
Conversation
Add dataset-scoped and pipeline_run_id-scoped memify status endpoints for asynchronous memify execution. Include focused API tests, README/docs rationale for pipeline_run_id usage, and a small HTTP example for polling memify status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a small status API for async memify runs.
You can now:
GET /api/v1/memify/statusto fetch the latest memify run for a datasetGET /api/v1/memify/status/{pipeline_run_id}to track one specific background runIt also includes focused API tests, a short example, and docs that explain why
pipeline_run_idis the right polling key for async memify.A couple of details worth calling out
While working through this, I tightened two things that seemed important before opening the PR:
run_info.datadataset_idWhy this shape
The endpoint is meant to be cheap to poll and predictable to use:
pipeline_run_idValidation
I checked this with focused unit tests and with a live HTTP probe against the branch build.