Feature/credential resource with enabled flag#1518
Open
Conversation
ghost
assigned
Contributor
|
Before merging this, I think that we need to have a wider discussion on the implications of having this flag. First, is this really appropriate for all credentials? (E.g. it isn't clear to me what a disabled public SSH key means.) Second, how does this affect the login process? And third, can/should we ignore the enabled flag in certain circumstances? (E.g. user requests the termination of a deployment but the associated credential is disabled.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connected to #1467