Fix pluralization of lynx, quiz and jeans#571
Open
cool-RR wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #403.
Three words were getting bad plurals:
pluralize("lynx")gave "lynges". The classical rule([iay])nx$ -> ngesis right for larynx and pharynx, but there's no such word as "lynges". Added an explicitlynx -> lynxesrule (Merriam-Webster lists "lynx" and "lynxes" as the plurals).pluralize("jeans")gave "jeanss". Added "jeans" to the uninflected lists, next to its cousins breeches and britches, on both the pluralize and singularize sides.pluralize("quiz")gave "quizs". I found this one while reproducing the issue. Funny enough,singularizealready had aquizzes -> quizrule, so the plural side just never kept up its end of the deal. Addedquiz -> quizzes, pluslynxes -> lynxto the irregular singulars so round trips work.Added tests for all three words in both directions. The whole suite passes.