Add 150ms tail buffer after Fn release#4
Open
croshank wants to merge 1 commit intosmallest-inc:mainfrom
Open
Conversation
When the user releases Fn, audio capture now continues for 150ms before stopping. This prevents the final word from being cut off mid-utterance, which happens because key-up fires before the speaker's articulatory gesture is complete.
EntelligenceAI PR SummaryFixes audio clipping of the last spoken word in
Confidence Score: 5/5 - Safe to MergeSafe to merge — this PR introduces a focused 150ms tail buffer in Key Findings:
Files requiring special attention
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you release the Fn key, audio capture stops immediately. If you're still finishing a word as you let go, the tail end gets clipped and the STT misses it.
This adds a 150ms delay between key-up and stopping the audio capture, giving the mic time to pick up the rest of the utterance before the stream is finalized.
One-line change in
AgentViewModel.stopListening().