Augment parameter schema with type's schema when no type given

[Pepo48]

… is set

• merge type, enum and format from the Java field type into the existing partial schema when it has no type set

Closes: #2595

[MikeEdgar]

Thanks for the PR @Pepo48 . I plan to review later today/tomorrow. I'm wondering if this issue affects schema handling generally and not just for parameters. E.g. does it happen for a property within another schema as well?

[Pepo48]

@MikeEdgar I also wondered about this earlier and at least based on what I see from my research is that it doesn't affect schema properties. The POJO property pipeline handles this correctly via TypeProcessor.processType(), which resolves enums before @Schema is read.

The bug is in mapParameterSchema() in AbstractParameterProcessor, which handles all parameter types, not just @BeanParam fields. Verified on @QueryParam and @HeaderParam, both as @BeanParam fields and direct method arguments. In all cases, parameterHasSchema() returns early when any schema object exists, skipping type resolution entirely.

But, please, recheck this thoroughly, just to be on the safe side. 😊

[MikeEdgar]

@Pepo48 pardon the delay, I am still thinking through this one. Your change works well for the narrow set of attributes in the new logic (type, enumeration, format), but really the issue impacts any type that is currently not being introspected. Granted, this can easily be worked around by adding implementation = SomeClass.class to the @Schema annotation nested within the @Parameter, but I think it might be best to handle it generally for more than just enumerations.

[Pepo48]

Hey @MikeEdgar, I found some time to look and it again. I verified one by one with all 7 types (enum, Integer, Double, Long, Boolean, LocalDate, UUID) that they all lose their type info when @Schema(defaultValue) is present.

I tried to replace the manual property merge with a simpler approach. For ref types (UUID, LocalDate, enum), the $ref is now set on the existing schema, so enums are no longer a special case, they just behave like any other ref type. For non-ref types (Integer, Boolean, etc.), mergeObjects fills in type/format while preserving defaultValue.

Is this roughly roughly the approach you had in mind? (I pushed the changes as a separate commit for now)

[MikeEdgar]

@Pepo48 I pushed a commit with some more test scenarios in the same test case and handling for multi-variant parameter content (i.e., >1 schema per parameter).

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud