Fix issues on gotip#1072
Merged
Merged
Conversation
In Go 1.27 `RawSignatureAlgorithm` was added. This causes equality tests to fail. These are now cleared from the CSR before equality checks are performed, similar to other "raw" properties.
hslatman
force-pushed
the
herman/gotip-fixes-20260716
branch
from
July 22, 2026 17:48
8df1bd7 to
fdebce2
Compare
maraino
approved these changes
Jul 22, 2026
maraino
left a comment
maraino
left a comment
Contributor
There was a problem hiding this comment.
lgtm, an improvement to this would be to clear all Raw* data that we need for the test to pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues when I ran it against
gotip:Signmethod now checks if the length is correct, and returns an error otherwise.