Fix Windows PATH registry reading and cmd.exe escaping for Issue #302

[Dumbris]

Problem

MCP servers fail on Windows with 'uv' is not recognized as an internal or external command when mcpproxy is launched via installer/auto-start without inheriting the user's PATH environment variable.

Reported in: #302

Root Cause

1. Windows installer launches mcpproxy-tray with minimal PATH (C:\Windows\System32)
2. Tray passes this minimal PATH to the core process
3. Core only had hardcoded discovery of 4-7 common paths
4. User's full PATH stored in Windows registry (28-34 directories) was never read
5. Tools installed in user directories (.cargo\bin, go\bin, etc.) were not found

Solution

1. Windows Registry PATH Reading ✅

Implemented automatic reading of user PATH from Windows registry:

• Reads HKEY_CURRENT_USER\Environment\Path (user-specific PATH)
• Reads HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment\Path (system PATH)
• Automatically expands environment variables (%USERPROFILE%, %APPDATA%, etc.)
• Falls back to expanded hardcoded discovery list if registry read fails

2. cmd.exe Escaping Fix ✅

Fixed command escaping for paths with spaces:

• Removed incorrect backslash escaping (\") which doesn't work in cmd.exe
• Auto-strips user-added quotes from command paths in JSON config
• Properly quotes paths containing spaces for cmd.exe

Changes

New Files

• internal/secureenv/manager_windows.go - Windows registry PATH reading (89 lines)
• internal/secureenv/manager_unix.go - Unix stub (11 lines)
• internal/secureenv/manager_windows_test.go - Unit tests (201 lines)

Modified Files

• internal/secureenv/manager.go - Registry reading integration
• internal/upstream/core/connection_stdio.go - cmd.exe escaping fix

Total: 351 lines added/modified across 5 files

Test Results

Unit Tests ✅

$ go test ./internal/secureenv -v -run TestReadWindowsRegistryPath
✅ PASS: Registry reading successful (34 directories)

$ go test ./internal/secureenv -v -run TestDiscoverWindowsPathsWithEmptyEnvironment
✅ PASS: Empty PATH recovery successful (28 paths)

$ go test ./internal/secureenv -v
✅ PASS: All Windows tests passing

Impact

Before	After
4-7 hardcoded paths	28-34 paths from registry ✅
uv not found ❌	uv found in .cargo\bin ✅
Paths with spaces fail ❌	Paths with spaces work ✅
Tools in .cargo\bin never found ❌	Found via registry ✅

Platform Compatibility

• Windows: Registry reading provides equivalent of Unix shell's -l flag ✅
• macOS/Linux: No changes, continues using shell wrapping ✅
• Backward Compatible: 100% - all existing configs work unchanged ✅

Performance

• Registry read overhead: <1ms (negligible)
• No impact on existing code paths
• One-time read during server initialization

---

This PR makes Windows a first-class citizen for mcpproxy! 🎉

Windows users can now use MCP servers with tools in user directories (Rust, Go, Python, Node.js) without manual PATH configuration.

Fixes #302

[cloudflare-workers-and-pages]

Deploying mcpproxy-docs with    Cloudflare Pages

Latest commit:	9a7bb08
Status:	✅  Deploy successful!
Preview URL:	https://18b90941.mcpproxy-docs.pages.dev
Branch Preview URL:	https://fix-windows-path-registry-is.mcpproxy-docs.pages.dev

View logs

[github-actions]

📦 Build Artifacts

Workflow Run: View Run
Branch: fix/windows-path-registry-issue-302

Available Artifacts

• archive-darwin-amd64 (23 MB)
• archive-darwin-arm64 (21 MB)
• archive-linux-amd64 (12 MB)
• archive-linux-arm64 (11 MB)
• archive-windows-amd64 (23 MB)
• archive-windows-arm64 (21 MB)
• frontend-dist-pr (0 MB)
• installer-dmg-darwin-amd64 (26 MB)
• installer-dmg-darwin-arm64 (23 MB)

How to Download

Option 1: GitHub Web UI (easiest)

1. Go to the workflow run page linked above
2. Scroll to the bottom "Artifacts" section
3. Click on the artifact you want to download

Option 2: GitHub CLI

gh run download 22021452480 --repo smart-mcp-proxy/mcpproxy-go

Note: Artifacts expire in 14 days.