✅ Quality Of Life Additions and Bug Fixes#1357
Open
ethxnblxd wants to merge 12 commits intosmartcmd:mainfrom
Open
✅ Quality Of Life Additions and Bug Fixes#1357ethxnblxd wants to merge 12 commits intosmartcmd:mainfrom
ethxnblxd wants to merge 12 commits intosmartcmd:mainfrom
Conversation
✅ Added Ctrl + Q to drop slot/stack ✅ Added prevention of switching hotbar slots whilst in menus [⚠️ PARTIALLY COMPLETE] Added dropping items in the inventory menu by selecting and clicking outside of the inventory menu to drop (left click = stack, right click = 1 item) (havent yet implemented Q dropping or CTRL + Q dropping for menus) ✅ Fixed pressing escape to exit chat opens pause menu ✅ Added ctrl + (left/right arrow to jump words when typing) ✅ Fixed Tab Key opening PlayerList whilst being in chat ✅ added '/' bind to open chat with a slash for command execution [⚠️ PARTIALLY COMPLETE] added support for CTRL + Backspace to delete a full word when chatting (doesnt execute properly)
Collaborator
|
What bugs are actually fixed here?
This looks like the only actual "bugfix." Please make a new PR for that specific bugfix, unless there is more reason for it. Everything else here looks like it might be out of scope for this project. Please take a look at our CONTRIBUTING.md for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
changes are as below:
GAME LOGIC (PC SUPPORT ONLY)
GUI
Needs logic implementation. tooltips are done already
CRAFTING MENU (i think PC SUPPORT ONLY)
Needs Implementation of Q dropping and CTRL + Q dropping
CHAT MENU
this doesnt work unless i spam ctrl + backspace a few times its obviously not detecting the key down for some reason, also it occasionally prints out control chars when both keys are detected, even tho it blocks it in the input hander]
Changes
Previous Behavior
game did not have a implementation of the CTRL + Q to drop stack, the Hold Q to drop items
could change item slots whilst in menu's
could not drop items whilst in menus
Root Cause
bugs, design flaws, and its just a quality of life that makes the game a lot more nicer.
New Behavior
added a CTRL + Q to drop a stack from your hotbar. and adds Hold Q to drop items.
added prevention of changing item slots whilst in menus
can now drop items from inventory menu
can open chat with a pre slash for command execution
Fixed some issues with Gui
Fix Implementation
added a few new functions and code
AI Use Disclosure
no ai was used.
Related Issues