Skip to content

EDS - Add CloseSend call to BackfilledStream #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
friedemannf wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

EDS - Add CloseSend call to BackfilledStream #545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions eds/internal/store/stream.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,10 @@ func ReceiveFromStream[T any](ctx context.Context, stream grpc.ServerStreamingCl
go func() {
defer close(respChan)
defer close(errChan)
defer func(stream grpc.ServerStreamingClient[T]) {
// CloseSend always returns a nil error.
_ = stream.CloseSend()
}(stream)

for {
resp, err := stream.Recv()
Expand Down
Loading