[PRODCRE-1746] Use moved MustKeccakHash and EIPAddress from common#362
Merged
pavel-raykov merged 5 commits intodevelopfrom Feb 17, 2026
Merged
[PRODCRE-1746] Use moved MustKeccakHash and EIPAddress from common#362pavel-raykov merged 5 commits intodevelopfrom
pavel-raykov merged 5 commits intodevelopfrom
Conversation
Contributor
|
This was referenced Feb 17, 2026
Merged
Contributor
There was a problem hiding this comment.
Pull request overview
Updates chainlink-evm to use MustKeccakHash and EIP55Address implementations that have moved into chainlink-common, along with the required dependency bumps.
Changes:
- Switch
MustHashto callchainlink-common’s movedMustKeccakHash - Replace local
EIP55Address/ collection implementation with type aliases tochainlink-common’sethkey - Update Go dependencies (chainlink-common/keystore, Prometheus, libocr, etc.) and dependency graph docs
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/utils/utils.go | Routes hashing through chainlink-common’s moved keccak helper |
| pkg/types/address.go | Replaces local address types/logic with aliases + wrappers to ethkey |
| pkg/types/address_test.go | Removes EIP55 address tests previously covering this repo’s exported API |
| pkg/config/mocks/workflow.go | Updates mocks to use ethkey.EIP55Address and common types |
| pkg/config/mocks/gas_estimator.go | Updates mocks to use ethkey.EIP55Address |
| go.mod | Bumps dependencies to versions that include the moved types/helpers |
| go.sum | Lockfile updates for bumped/added transitive dependencies |
| go.md | Updates dependency graph to reflect new transitive deps |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
george-dorin
approved these changes
Feb 17, 2026
joaoluisam
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires smartcontractkit/chainlink-common#1837