Skip to content

Comments

[PRODCRE-1746] Use moved MustKeccakHash and EIPAddress from common#362

Merged
pavel-raykov merged 5 commits intodevelopfrom
move-keys5
Feb 17, 2026
Merged

[PRODCRE-1746] Use moved MustKeccakHash and EIPAddress from common#362
pavel-raykov merged 5 commits intodevelopfrom
move-keys5

Conversation

@pavel-raykov
Copy link
Contributor

@pavel-raykov pavel-raykov changed the title [PRODCRE-1746] Used moved keys MustKeccakHash and EIPAddress from common [PRODCRE-1746] Used moved MustKeccakHash and EIPAddress from common Feb 17, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2026

⚠️ API Diff Results - Breaking changes detected

📦 Module: github-com-smartcontractkit-chainlink-evm

🔴 Breaking Changes (39)

pkg/config.DAOracle (1)
  • OracleAddress — Type changed:
func(
)
*github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
pkg/config.GasEstimator (1)
  • SenderAddress — Type changed:
func(
)
*github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
pkg/config.Workflow (2)
  • ForwarderAddress — Type changed:
func(
)
*github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
  • FromAddress — Type changed:
func(
)
*github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
pkg/config/mocks.(*GasEstimator) (1)
  • SenderAddress — Type changed:
func(
)
- *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
+ *github.com/smartcontractkit/chainlink-common/keystore/corekeys/ethkey.EIP55Address
pkg/config/mocks.(*GasEstimator_SenderAddress_Call) (2)
  • Return — Type changed:
func(
  - *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
  + *github.com/smartcontractkit/chainlink-common/keystore/corekeys/ethkey.EIP55Address
)
*GasEstimator_SenderAddress_Call
  • RunAndReturn — Type changed:
func(
  - func() *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
  + func() *github.com/smartcontractkit/chainlink-common/keystore/corekeys/ethkey.EIP55Address
)
*GasEstimator_SenderAddress_Call
pkg/config/mocks.(*Workflow) (2)
  • ForwarderAddress — Type changed:
func(
)
- *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
+ *github.com/smartcontractkit/chainlink-common/keystore/corekeys/ethkey.EIP55Address
  • FromAddress — Type changed:
func(
)
- *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
+ *github.com/smartcontractkit/chainlink-common/keystore/corekeys/ethkey.EIP55Address
pkg/config/mocks.(*Workflow_ForwarderAddress_Call) (2)
  • Return — Type changed:
func(
  - *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
  + *github.com/smartcontractkit/chainlink-common/keystore/corekeys/ethkey.EIP55Address
)
*Workflow_ForwarderAddress_Call
  • RunAndReturn — Type changed:
func(
  - func() *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
  + func() *github.com/smartcontractkit/chainlink-common/keystore/corekeys/ethkey.EIP55Address
)
*Workflow_ForwarderAddress_Call
pkg/config/mocks.(*Workflow_FromAddress_Call) (2)
  • Return — Type changed:
func(
  - *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
  + *github.com/smartcontractkit/chainlink-common/keystore/corekeys/ethkey.EIP55Address
)
*Workflow_FromAddress_Call
  • RunAndReturn — Type changed:
func(
  - func() *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
  + func() *github.com/smartcontractkit/chainlink-common/keystore/corekeys/ethkey.EIP55Address
)
*Workflow_FromAddress_Call
pkg/config/toml.Chain (3)
  • FlagsContractAddress — Type changed:
  *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
)
  • LinkContractAddress — Type changed:
  *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
)
  • OperatorFactoryAddress — Type changed:
  *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
)
pkg/config/toml.DAOracle (1)
  • OracleAddress — Type changed:
  *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
)
pkg/config/toml.EVMConfig (3)
  • FlagsContractAddress — Type changed:
  *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
)
  • LinkContractAddress — Type changed:
  *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
)
  • OperatorFactoryAddress — Type changed:
  *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
)
pkg/config/toml.GasEstimator (1)
  • SenderAddress — Type changed:
  *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
)
pkg/config/toml.KeySpecific (1)
  • Key — Type changed:
  *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
)
pkg/config/toml.Workflow (2)
  • ForwarderAddress — Type changed:
  *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
)
  • FromAddress — Type changed:
  *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
)
pkg/gas.GasEstimatorConfig (1)
  • SenderAddress — Type changed:
func(
)
*github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
pkg/gas/rollups.(*TestDAOracle) (1)
  • OracleAddress — Type changed:
func(
)
*github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
pkg/gas/rollups.TestDAOracle (1)
  • OracleAddress — Type changed:
  *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
)
pkg/interceptors/mantle (1)
  • NewInterceptor — Type changed:
func(
  context.Context, 
  github.com/smartcontractkit/chainlink-evm/pkg/client.Client, 
  *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
)
(*Interceptor, error)
pkg/txm/integration-tests.AppConfig (2)
  • SenderAddress — Type changed:
func(
)
*github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
  • SenderAddressF — Type changed:
  *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
)
pkg/txm/integration-tests.DAOracle (2)
  • OracleAddress — Type changed:
func(
)
*github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
  • OracleAddressF — Type changed:
  *github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
)
pkg/txmgr.(*TestDAOracleConfig) (1)
  • OracleAddress — Type changed:
func(
)
*github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
pkg/txmgr.(*TestGasEstimatorConfig) (1)
  • SenderAddress — Type changed:
func(
)
*github.com/smartcontractkit/chainlink-evm/pkg/types.EIP55Address
pkg/types (5)
  • EIP55Address — Type changed:
  - EIP55Address
  + github.com/smartcontractkit/chainlink-common/keystore/corekeys/ethkey.EIP55Address
)
  • EIP55AddressCollection — Type changed:
  - EIP55AddressCollection
  + github.com/smartcontractkit/chainlink-common/keystore/corekeys/ethkey.EIP55AddressCollection
)
  • EIP55AddressFromAddress — Type changed:
func(
  github.com/ethereum/go-ethereum/common.Address
)
EIP55Address
  • MustEIP55Address — Type changed:
func(
  string
)
EIP55Address
  • NewEIP55Address — Type changed:
func(
  string
)
(EIP55Address, error)

📄 View full apidiff report

@pavel-raykov pavel-raykov changed the title [PRODCRE-1746] Used moved MustKeccakHash and EIPAddress from common [PRODCRE-1746] Use moved MustKeccakHash and EIPAddress from common Feb 17, 2026
@pavel-raykov pavel-raykov marked this pull request as ready for review February 17, 2026 16:21
@pavel-raykov pavel-raykov requested review from a team as code owners February 17, 2026 16:21
Copilot AI review requested due to automatic review settings February 17, 2026 16:21
@pavel-raykov pavel-raykov requested a review from a team as a code owner February 17, 2026 16:21
@pavel-raykov pavel-raykov requested a review from jmank88 February 17, 2026 16:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates chainlink-evm to use MustKeccakHash and EIP55Address implementations that have moved into chainlink-common, along with the required dependency bumps.

Changes:

  • Switch MustHash to call chainlink-common’s moved MustKeccakHash
  • Replace local EIP55Address / collection implementation with type aliases to chainlink-common’s ethkey
  • Update Go dependencies (chainlink-common/keystore, Prometheus, libocr, etc.) and dependency graph docs

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
pkg/utils/utils.go Routes hashing through chainlink-common’s moved keccak helper
pkg/types/address.go Replaces local address types/logic with aliases + wrappers to ethkey
pkg/types/address_test.go Removes EIP55 address tests previously covering this repo’s exported API
pkg/config/mocks/workflow.go Updates mocks to use ethkey.EIP55Address and common types
pkg/config/mocks/gas_estimator.go Updates mocks to use ethkey.EIP55Address
go.mod Bumps dependencies to versions that include the moved types/helpers
go.sum Lockfile updates for bumped/added transitive dependencies
go.md Updates dependency graph to reflect new transitive deps

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pavel-raykov pavel-raykov merged commit 755485c into develop Feb 17, 2026
38 of 39 checks passed
@pavel-raykov pavel-raykov deleted the move-keys5 branch February 17, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants