Skip to content

Comments

[DO NOT PUSH TO THIS] rebuild with 1.63#319

Open
FelixFan1992 wants to merge 10 commits intodevelopfrom
upgrade-1.63
Open

[DO NOT PUSH TO THIS] rebuild with 1.63#319
FelixFan1992 wants to merge 10 commits intodevelopfrom
upgrade-1.63

Conversation

@FelixFan1992
Copy link
Collaborator

@FelixFan1992 FelixFan1992 commented Jan 12, 2026

This PR is used as the reference point for start-kit while we are working on a permanent fix for 1.63.
Do not push to it and do not merge.

@FelixFan1992 FelixFan1992 requested a review from a team as a code owner January 12, 2026 16:28
@github-actions
Copy link

👋 FelixFan1992, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link

Hello, @FelixFan1992! 👋
This Pull Request requires regenerating the contract bindings
Run:

  • nix develop -c task bindings:generate
  • Commit the updates

env.destroy();
}

#[test]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove

mcms_owner = "0x0"

[dev-addresses]
mcms = "0x0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did we get around the failing tests?

@FelixFan1992 FelixFan1992 changed the title rebuild with 1.63 [DO NOT PUSH TO THIS] rebuild with 1.63 Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants