refactor: Update SUI client by faisal-chainlink · Pull Request #774 · smartcontractkit/mcms

faisal-chainlink · 2026-06-04T17:33:14Z

This PR includes the following changes:

Updates the Sui SDK references to correspond to the gRPC migration changes in chainlink-sui. This primarily includes dropping the ISuiAPI reference (old version of the Sui SDK) in favor of using a client interface exported by chainlink-sui/relayer/client.
Update the mocked interface for Sui in this repo.
General lint and deps version bumps.

faisal-chainlink · 2026-06-08T16:32:34Z

@JohnChangUK @RodrigoAD pinging because you worked on MCMS for Sui. There's a test that currently fails due to a fallback decode (object name --> decodes to address). Is that test / behavior necessary? The E2E tests are passing here.

Copilot

Pull request overview

This PR refactors the Sui integration to use the chainlink-sui/relayer/client bindings (gRPC/PTB-backed) instead of the block-vision/sui-go-sdk/sui ISuiAPI client, and updates unit/e2e tests plus generated mocks accordingly.

Changes:

Replace sui.ISuiAPI with cslclient.BindingsClient across Sui inspector/executor/configurer/timelock components and chainwrappers.
Add a Sui helper to build a gRPC-backed bindings client from a node URL; update e2e setup to use it.
Regenerate/update mockery mocks and config to target the new Sui client interfaces.

Reviewed changes

Copilot reviewed 30 out of 53 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
taskfiles/generate/Taskfile.yml	Fix/normalize mock generation task command indentation.
sdk/ton/mocks/wallet.go	Mock import reordering (generated/formatting).
sdk/ton/mocks/api.go	Mock import reordering (generated/formatting).
sdk/sui/timelock_inspector.go	Switch TimelockInspector client type to `BindingsClient`.
sdk/sui/timelock_inspector_test.go	Update tests to use `NewBindingsClient` mock.
sdk/sui/timelock_executor.go	Switch TimelockExecutor client + `ExecutePTB` signature to `BindingsClient`.
sdk/sui/timelock_executor_test.go	Update tests to use `NewBindingsClient` mock and new `ExecutePTB` signature.
sdk/sui/mocks/sui/suiptbclient.go	Add generated mock for `SuiPTBClient`.
sdk/sui/mocks/sui/bindingsclient.go	Add generated mock for `BindingsClient`.
sdk/sui/mocks/mcmsdeployer/imcmsdeployer.go	Mock import reordering (generated/formatting).
sdk/sui/mocks/mcms/mcmsencoder.go	Mock import reordering (generated/formatting).
sdk/sui/mocks/mcms/imcmsdevinspect.go	Mock import reordering (generated/formatting).
sdk/sui/mocks/mcms/imcms.go	Mock import reordering (generated/formatting).
sdk/sui/mocks/feequoter/feequoterencoder.go	Mock import reordering (generated/formatting).
sdk/sui/mocks/bindutils/iboundcontract.go	Mock import reordering (generated/formatting).
sdk/sui/inspector.go	Switch Inspector client type to `BindingsClient`.
sdk/sui/inspector_test.go	Update tests to use `NewBindingsClient` mock.
sdk/sui/executor.go	Switch Executor client type + `ExecutePTB` signature to `BindingsClient`.
sdk/sui/executor_test.go	Update tests to use `NewBindingsClient` mock and new `ExecutePTB` signature.
sdk/sui/executing_callback.go	Switch executing callback params to use `BindingsClient`.
sdk/sui/executing_callback_test.go	Update tests for `BindingsClient` and updated function types.
sdk/sui/configurer.go	Switch Configurer client type to `BindingsClient`.
sdk/sui/configurer_test.go	Update tests to use `NewBindingsClient` mock.
sdk/sui/client_helper.go	Add helper to create a gRPC-backed `BindingsClient` from an RPC URL.
sdk/solana/mocks/jsonrpcclient.go	Mock import formatting cleanup.
sdk/mocks/timelock_executor.go	Mock import formatting cleanup.
sdk/mocks/timelock_converter.go	Mock import formatting cleanup.
sdk/mocks/timelock_configurer.go	Add generated mock for `TimelockConfigurer`.
sdk/mocks/simulator.go	Mock import formatting cleanup.
sdk/mocks/operation_id.go	Add generated mock for `OperationID`.
sdk/mocks/inspector.go	Mock import formatting cleanup.
sdk/mocks/executor.go	Mock import formatting cleanup.
sdk/mocks/decoder.go	Mock import reordering (generated/formatting).
sdk/evm/mocks/contract_deploy_backend.go	Mock import reordering (generated/formatting).
sdk/evm/bindings/mocks/rbac_timelock_interface.go	Mock import reordering (generated/formatting).
sdk/evm/bindings/mocks/many_chain_multi_sig_interface.go	Mock import reordering (generated/formatting).
sdk/evm/bindings/mocks/call_proxy_interface.go	Mock import reordering (generated/formatting).
sdk/aptos/mocks/mcms/mcms/mcms.go	Mock import reordering (generated/formatting).
sdk/aptos/mocks/mcms/mcms/mcms_encoder.go	Mock import reordering (generated/formatting).
sdk/aptos/mocks/mcms/mcms.go	Mock import reordering (generated/formatting).
sdk/aptos/mocks/mcms/mcms_executor/mcms_executor.go	Mock import reordering (generated/formatting).
sdk/aptos/mocks/aptos/transactionsigner.go	Mock import formatting cleanup.
sdk/aptos/mocks/aptos/rpcclient.go	Mock import reordering (generated/formatting).
go.mod	Bump `chainlink-sui`, add `chainlink-common` direct dep, add `go-cache` (needed by generated mocks).
go.sum	Update sums for new/updated dependencies.
e2e/tests/sui/common.go	Switch e2e suite client type to `BindingsClient`.
e2e/tests/setup.go	Create Sui gRPC bindings client via new helper; update types/logging accordingly.
chainwrappers/timelock_executors_test.go	Update Sui timelock executor test to use `NewBindingsClient` mock.
chainwrappers/mocks/chain_accessor.go	Update ChainAccessor mock to return `BindingsClient` for Sui and adjust imports.
chainwrappers/executors_test.go	Update Sui executor test to use `NewBindingsClient` mock.
chainwrappers/chainaccessor.go	Update ChainAccessor interface: `SuiClient` now returns `BindingsClient`.
.mockery.yaml	Update mockery config to generate mocks for `chainlink-sui/relayer/client` interfaces.

Files not reviewed (20)

chainwrappers/mocks/chain_accessor.go: Language not supported
sdk/aptos/mocks/aptos/rpcclient.go: Language not supported
sdk/aptos/mocks/aptos/transactionsigner.go: Language not supported
sdk/aptos/mocks/mcms/mcms.go: Language not supported
sdk/aptos/mocks/mcms/mcms/mcms.go: Language not supported
sdk/aptos/mocks/mcms/mcms/mcms_encoder.go: Language not supported
sdk/aptos/mocks/mcms/mcms_executor/mcms_executor.go: Language not supported
sdk/evm/bindings/mocks/call_proxy_interface.go: Language not supported
sdk/evm/bindings/mocks/many_chain_multi_sig_interface.go: Language not supported
sdk/evm/bindings/mocks/rbac_timelock_interface.go: Language not supported
sdk/evm/mocks/contract_deploy_backend.go: Language not supported
sdk/mocks/decoder.go: Language not supported
sdk/mocks/executor.go: Language not supported
sdk/mocks/inspector.go: Language not supported
sdk/mocks/operation_id.go: Language not supported
sdk/mocks/simulator.go: Language not supported
sdk/mocks/timelock_configurer.go: Language not supported
sdk/mocks/timelock_converter.go: Language not supported
sdk/mocks/timelock_executor.go: Language not supported
sdk/solana/mocks/jsonrpcclient.go: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

FelixFan1992 · 2026-06-09T13:33:04Z

can you fix the failing tests?

Copilot

Pull request overview

Copilot reviewed 30 out of 53 changed files in this pull request and generated 2 comments.

Files not reviewed (20)

chainwrappers/mocks/chain_accessor.go: Language not supported
sdk/aptos/mocks/aptos/rpcclient.go: Language not supported
sdk/aptos/mocks/aptos/transactionsigner.go: Language not supported
sdk/aptos/mocks/mcms/mcms.go: Language not supported
sdk/aptos/mocks/mcms/mcms/mcms.go: Language not supported
sdk/aptos/mocks/mcms/mcms/mcms_encoder.go: Language not supported
sdk/aptos/mocks/mcms/mcms_executor/mcms_executor.go: Language not supported
sdk/evm/bindings/mocks/call_proxy_interface.go: Language not supported
sdk/evm/bindings/mocks/many_chain_multi_sig_interface.go: Language not supported
sdk/evm/bindings/mocks/rbac_timelock_interface.go: Language not supported
sdk/evm/mocks/contract_deploy_backend.go: Language not supported
sdk/mocks/decoder.go: Language not supported
sdk/mocks/executor.go: Language not supported
sdk/mocks/inspector.go: Language not supported
sdk/mocks/operation_id.go: Language not supported
sdk/mocks/simulator.go: Language not supported
sdk/mocks/timelock_configurer.go: Language not supported
sdk/mocks/timelock_converter.go: Language not supported
sdk/mocks/timelock_executor.go: Language not supported
sdk/solana/mocks/jsonrpcclient.go: Language not supported

Copilot

Pull request overview

Copilot reviewed 30 out of 53 changed files in this pull request and generated 2 comments.

Files not reviewed (20)

chainwrappers/mocks/chain_accessor.go: Language not supported
sdk/aptos/mocks/aptos/rpcclient.go: Language not supported
sdk/aptos/mocks/aptos/transactionsigner.go: Language not supported
sdk/aptos/mocks/mcms/mcms.go: Language not supported
sdk/aptos/mocks/mcms/mcms/mcms.go: Language not supported
sdk/aptos/mocks/mcms/mcms/mcms_encoder.go: Language not supported
sdk/aptos/mocks/mcms/mcms_executor/mcms_executor.go: Language not supported
sdk/evm/bindings/mocks/call_proxy_interface.go: Language not supported
sdk/evm/bindings/mocks/many_chain_multi_sig_interface.go: Language not supported
sdk/evm/bindings/mocks/rbac_timelock_interface.go: Language not supported
sdk/evm/mocks/contract_deploy_backend.go: Language not supported
sdk/mocks/decoder.go: Language not supported
sdk/mocks/executor.go: Language not supported
sdk/mocks/inspector.go: Language not supported
sdk/mocks/operation_id.go: Language not supported
sdk/mocks/simulator.go: Language not supported
sdk/mocks/timelock_configurer.go: Language not supported
sdk/mocks/timelock_converter.go: Language not supported
sdk/mocks/timelock_executor.go: Language not supported
sdk/solana/mocks/jsonrpcclient.go: Language not supported

cl-sonarqube-production · 2026-06-10T20:58:21Z

Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Copilot

Pull request overview

Copilot reviewed 31 out of 54 changed files in this pull request and generated no new comments.

Files not reviewed (20)

chainwrappers/mocks/chain_accessor.go: Language not supported
sdk/aptos/mocks/aptos/rpcclient.go: Language not supported
sdk/aptos/mocks/aptos/transactionsigner.go: Language not supported
sdk/aptos/mocks/mcms/mcms.go: Language not supported
sdk/aptos/mocks/mcms/mcms/mcms.go: Language not supported
sdk/aptos/mocks/mcms/mcms/mcms_encoder.go: Language not supported
sdk/aptos/mocks/mcms/mcms_executor/mcms_executor.go: Language not supported
sdk/evm/bindings/mocks/call_proxy_interface.go: Language not supported
sdk/evm/bindings/mocks/many_chain_multi_sig_interface.go: Language not supported
sdk/evm/bindings/mocks/rbac_timelock_interface.go: Language not supported
sdk/evm/mocks/contract_deploy_backend.go: Language not supported
sdk/mocks/decoder.go: Language not supported
sdk/mocks/executor.go: Language not supported
sdk/mocks/inspector.go: Language not supported
sdk/mocks/operation_id.go: Language not supported
sdk/mocks/simulator.go: Language not supported
sdk/mocks/timelock_configurer.go: Language not supported
sdk/mocks/timelock_converter.go: Language not supported
sdk/mocks/timelock_executor.go: Language not supported
sdk/solana/mocks/jsonrpcclient.go: Language not supported

faisal-chainlink added 8 commits June 4, 2026 20:17

update sui client

6376a86

update Sui mocks and regenerate

da0bd7d

update chainlink-sui ref

1cbe349

Merge branch 'main' into feat/sui-grpc-migration

b72c6e7

tidy

2708f04

typo

dd10202

Merge branch 'main' into feat/sui-grpc-migration

16f0b96

formatting

50bf251

faisal-chainlink changed the title ~~Update SUI client~~ chore(main): Update SUI client Jun 8, 2026

faisal-chainlink changed the title ~~chore(main): Update SUI client~~ refactor: Update SUI client Jun 8, 2026

faisal-chainlink marked this pull request as ready for review June 8, 2026 16:31

faisal-chainlink requested a review from a team as a code owner June 8, 2026 16:31

Copilot AI review requested due to automatic review settings June 8, 2026 16:31

product-security-plaid-production Bot requested a review from ChrisAmora June 8, 2026 16:31

Copilot started reviewing on behalf of faisal-chainlink June 8, 2026 16:31 View session

Copilot AI reviewed Jun 8, 2026

View reviewed changes

Comment thread sdk/sui/client_helper.go

faisal-chainlink requested review from FelixFan1992, JohnChangUK and RodrigoAD June 8, 2026 16:41

faisal-chainlink mentioned this pull request Jun 8, 2026

[Chore] Re-enable E2E tests smartcontractkit/chainlink-sui#401

Merged

faisal-chainlink added 2 commits June 9, 2026 19:28

update chainlink-sui dep ref

d355bc3

Merge branch 'main' into feat/sui-grpc-migration

1ef6436

Copilot AI review requested due to automatic review settings June 9, 2026 15:47

Copilot started reviewing on behalf of faisal-chainlink June 9, 2026 15:47 View session

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Comment thread sdk/sui/client_helper.go

Comment thread sdk/sui/client_helper.go

faisal-chainlink added 2 commits June 9, 2026 19:53

update chainlink-sui dep ref

31b72a6

update chainlink-sui dep ref

2e33fc6

Copilot AI review requested due to automatic review settings June 9, 2026 16:12

Copilot started reviewing on behalf of faisal-chainlink June 9, 2026 16:12 View session

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Comment thread sdk/sui/client_helper.go

Comment thread sdk/sui/client_helper.go

faisal-chainlink marked this pull request as draft June 9, 2026 16:23

faisal-chainlink added 4 commits June 11, 2026 00:22

remove chainlink-sui dep commit hash ref

60a69a2

Merge branch 'main' into feat/sui-grpc-migration

0e07c6a

tidy

53dd5b1

add client helper test

96a82c4

faisal-chainlink marked this pull request as ready for review June 10, 2026 21:07

Copilot AI review requested due to automatic review settings June 10, 2026 21:07

Copilot started reviewing on behalf of faisal-chainlink June 10, 2026 21:07 View session

Copilot AI reviewed Jun 10, 2026

View reviewed changes

FelixFan1992 approved these changes Jun 10, 2026

View reviewed changes

faisal-chainlink enabled auto-merge (squash) June 10, 2026 21:17

JohnChangUK approved these changes Jun 10, 2026

View reviewed changes

ChrisAmora approved these changes Jun 11, 2026

View reviewed changes

faisal-chainlink merged commit 3f43937 into main Jun 11, 2026
23 checks passed

faisal-chainlink deleted the feat/sui-grpc-migration branch June 11, 2026 00:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Update SUI client#774

refactor: Update SUI client#774
faisal-chainlink merged 16 commits into
mainfrom
feat/sui-grpc-migration

faisal-chainlink commented Jun 4, 2026 •

edited

Loading

Uh oh!

faisal-chainlink commented Jun 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

FelixFan1992 commented Jun 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

cl-sonarqube-production Bot commented Jun 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

faisal-chainlink commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

faisal-chainlink commented Jun 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

FelixFan1992 commented Jun 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

cl-sonarqube-production Bot commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

faisal-chainlink commented Jun 4, 2026 •

edited

Loading

cl-sonarqube-production Bot commented Jun 10, 2026 •

edited

Loading