Skip to content

chore: Canton enum encoding dependency#788

Merged
JohnChangUK merged 1 commit into
mainfrom
enum-encode
Jun 16, 2026
Merged

chore: Canton enum encoding dependency#788
JohnChangUK merged 1 commit into
mainfrom
enum-encode

Conversation

@JohnChangUK

Copy link
Copy Markdown
Contributor

Description

Bump Canton dep

@JohnChangUK JohnChangUK requested a review from a team as a code owner June 15, 2026 23:43
Copilot AI review requested due to automatic review settings June 15, 2026 23:43
@github-actions

Copy link
Copy Markdown

👋 JohnChangUK, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@JohnChangUK JohnChangUK changed the title Canton enum encoding dependency chore: Canton enum encoding dependency Jun 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Canton/go-daml dependency set and adds a regression test to ensure CCIP DeployRateLimiter enum fields are encoded using the expected ordinal-byte wire format.

Changes:

  • Bump github.com/smartcontractkit/chainlink-canton and github.com/smartcontractkit/go-daml (plus associated indirect dependency updates).
  • Add TestDecoder_DeployRateLimiter_EnumFields to validate enum encoding/decoding and round-trip behavior for DeployRateLimiter.
  • Refresh go.sum to match the module graph after the dependency bump.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
sdk/canton/decoder_test.go Adds a regression test covering enum byte-encoding for DeployRateLimiter and round-trip re-encoding behavior.
go.mod Bumps Canton/go-daml and several related direct/indirect dependencies.
go.sum Updates checksums for the new module versions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sdk/canton/decoder_test.go
Comment thread sdk/canton/decoder_test.go
@JohnChangUK JohnChangUK enabled auto-merge (squash) June 15, 2026 23:51
@cl-sonarqube-production

Copy link
Copy Markdown

@JohnChangUK JohnChangUK merged commit 085d81f into main Jun 16, 2026
26 of 27 checks passed
@JohnChangUK JohnChangUK deleted the enum-encode branch June 16, 2026 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants