Fix: incorrect strpos check in triggerTagNoCache #1182
Open
zigzagdev wants to merge 1 commit intosmarty-php:masterfrom
Open
Fix: incorrect strpos check in triggerTagNoCache #1182zigzagdev wants to merge 1 commit intosmarty-php:masterfrom
strpos check in triggerTagNoCache #1182zigzagdev wants to merge 1 commit intosmarty-php:masterfrom
Conversation
Using `!strpos(...)` incorrectly evaluates to true when `(` is at position 0, causing the nocache flag logic to be skipped. Replace with `strpos(...) === false` for correct behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
triggerTagNoCache()uses!strpos($variable, '(')to check if(is absentfrom
$variable. However,strposreturns0when(appears at position 0,and
!0evaluates totrue, incorrectly skipping the nocache flag logic.This replaces
!strpos(...)withstrpos(...) === false.References