Open
Conversation
northdpole
force-pushed
the
close-713-port-reachability-to-new-sdk
branch
2 times, most recently
from
992216c to
061361a
Compare
northdpole
force-pushed
the
close-713-port-reachability-to-new-sdk
branch
3 times, most recently
from
181e231 to
ff7ac96
Compare
northdpole
force-pushed
the
close-713-port-reachability-to-new-sdk
branch
from
ff7ac96 to
cba79aa
Compare
northdpole
force-pushed
the
close-713-port-reachability-to-new-sdk
branch
4 times, most recently
from
2b13f39 to
3a4cb70
Compare
|
It looks like this branch needs rebasing |
northdpole
force-pushed
the
close-713-port-reachability-to-new-sdk
branch
from
3a4cb70 to
042cd5d
Compare
added 7 commits
March 18, 2025 16:03
northdpole
force-pushed
the
close-713-port-reachability-to-new-sdk
branch
from
042cd5d to
59203ff
Compare
andream16
reviewed
Mar 19, 2025
| require ( | ||
| github.com/go-errors/errors v1.5.1 | ||
| github.com/package-url/packageurl-go v0.1.0 | ||
| github.com/smithy-security/smithy/sdk v0.0.4-alpha |
andream16
reviewed
Mar 19, 2025
| description: "Adds a boolean 'Reachable-Code' enrichment to the passed findings" | ||
| type: enricher | ||
| parameters: | ||
| - name: programming-language |
There was a problem hiding this comment.
Can we use snake case like in the other components?
andream16
reviewed
Mar 19, 2025
| executable: /bin/sh | ||
| args: | ||
| - -c | ||
| - atom reachables -o {{ sourceCodeWorkspace }}/app.atom -s {{ scratchWorkspace }}/reachables.json -l {{ .parameters.programming-language }} {{ sourceCodeWorkspace }} |
There was a problem hiding this comment.
Looks sus - do we need to break this in multilines?
andream16
reviewed
Mar 19, 2025
| executable: /bin/sh | ||
| args: | ||
| - -c | ||
| - atom reachables -o {{ sourceCodeWorkspace }}/app.atom -s {{ scratchWorkspace }}/reachables.json -l {{ .parameters.programming-language }} {{ sourceCodeWorkspace }} |
andream16
reviewed
Mar 19, 2025
| } | ||
| ) | ||
|
|
||
| func main() { |
There was a problem hiding this comment.
Couldn't we add this logic to the component itself to make sure that it's served by the SDK?
|
The git log needs some love |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.