bounded: make sure lap does not overflow into index#12
Open
link2xt wants to merge 1 commit intosmol-rs:masterfrom
link2xt:bounded-lap-overflow
Open
bounded: make sure lap does not overflow into index#12link2xt wants to merge 1 commit intosmol-rs:masterfrom link2xt:bounded-lap-overflow
link2xt wants to merge 1 commit intosmol-rs:masterfrom
link2xt:bounded-lap-overflow
Conversation
.wrapping_add() is not enuough to ensure this, it is possible to end up with index=1 if usize overflows. This is unlikely on 64-bit systems, but possible on 32-bit systems.
Member
|
this is still a problem, right? is it possible to build a test case that triggers this when running a 32bit application on 64bit or PAE kernel with enough RAM and maybe a list containing only ZST elements? |
Member
|
I think this is still an issue? #11 was already closed, but I'd like a test (and ideally a 32-bit-CI-run) that indicates that this is an issue. |
Member
|
@taiki-e I know that this crate is essentially a fork of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.wrapping_add() is not enuough to ensure this, it is possible to end
up with index=1 if usize overflows. This is unlikely on 64-bit
systems, but possible on 32-bit systems.