Skip to content

PHP8 upgrade and cleanup#15

Open
lane-smsg wants to merge 4 commits intomasterfrom
php8
Open

PHP8 upgrade and cleanup#15
lane-smsg wants to merge 4 commits intomasterfrom
php8

Conversation

@lane-smsg
Copy link
Copy Markdown

PHP8 upgrades.
Cleanup code.
Upgrade phpunit

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.93%. Comparing base (c3eac17) to head (225d04b).

Files with missing lines Patch % Lines
src/Resource/Base.php 77.77% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@              Coverage Diff              @@
##              master      #15      +/-   ##
=============================================
- Coverage     100.00%   98.93%   -1.07%     
  Complexity        47       47              
=============================================
  Files              6        6              
  Lines            160      187      +27     
=============================================
+ Hits             160      185      +25     
- Misses             0        2       +2     
Flag Coverage Δ
unittests 98.93% <94.44%> (-1.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants