build(deps): bump snapcore/action-publish from 9334eecb267cfd97a0ce3c8654215d095927252f to 214b86e5ca036ead1668c79afb81e550e6c54d40

.github/workflows/ci.yml

@@ -38,6 +38,7 @@ jobs:
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           persist-credentials: false
+          clean: false
 
       - name: Pnpm Setup
         uses: pnpm/action-setup@903f9c1a6ebcba6cf41d87230be49611ac97822e # v6.0.3
@@ -96,6 +97,7 @@ jobs:
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           persist-credentials: false
+          clean: false
 
       - name: Pnpm Setup
         uses: pnpm/action-setup@903f9c1a6ebcba6cf41d87230be49611ac97822e # v6.0.3
@@ -139,6 +141,7 @@ jobs:
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           persist-credentials: false
+          clean: false
 
       - name: Pnpm Setup
         uses: pnpm/action-setup@903f9c1a6ebcba6cf41d87230be49611ac97822e # v6.0.3
@@ -187,6 +190,7 @@ jobs:
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           persist-credentials: false
+          clean: false
 
       - name: Commit timestamp
         id: ts
@@ -235,6 +239,7 @@ jobs:
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           persist-credentials: false
+          clean: false
 
       - name: Commit timestamp
         id: ts
@@ -374,6 +379,7 @@ jobs:
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           persist-credentials: false
+          clean: false
 
       - name: Log in to GitHub Container Registry on seerr.home
         env:

.github/workflows/codeql.yml

@@ -40,6 +40,7 @@ jobs:
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           persist-credentials: false
+          clean: false
 
       - name: Initialize CodeQL
         uses: github/codeql-action/init@95e58e9a2cdfd71adc6e0353d5c52f41a045d225 # v4.35.2

.github/workflows/cypress.yml

@@ -40,6 +40,7 @@ jobs:
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           persist-credentials: false
+          clean: false
 
       - name: Set up Node.js
         uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0

.github/workflows/release-snap.yml

@@ -54,7 +54,7 @@ jobs:
         with:
           path: packaging/snap
 
-      - uses: snapcore/action-publish@9334eecb267cfd97a0ce3c8654215d095927252f # v1
+      - uses: snapcore/action-publish@214b86e5ca036ead1668c79afb81e550e6c54d40 # v1
         env:
           SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.SNAPCRAFT_STORE_CREDENTIALS }}
         with:

.prettierignore

@@ -3,6 +3,8 @@
 dist/
 config/
 cache/config.json
+.bookshelf-migration-lab
+.bookshelf-migration-lab/**
 pnpm-lock.yaml
 cypress/config/settings.cypress.json
 .github

cypress/e2e/discover.cy.ts

@@ -297,9 +297,7 @@ describe('Discover', () => {
     cy.contains('.slider-header', 'Recent Requests')
       .next('[data-testid=media-slider]')
       .contains('[data-testid=request-card]', 'Failed Card Album')
-      .find(
-        'a[href="/music/56565656-5656-5656-5656-565656565656?manage=1"]'
-      )
+      .find('a[href="/music/56565656-5656-5656-5656-565656565656?manage=1"]')
       .should('contain', 'Failed');
   });
 

deploy/bookshelf-hardcover-migration.mjs

@@ -507,6 +507,23 @@ const normalizePathComparable = (value) => {
   return normalized.replace(/\/+$/, '');
 };
 
+const normalizeReadarrRootFolderPath = (value) => {
+  const normalized = normalizeText(value).replace(/\\/g, '/');
+  const pathPattern = /^\/[A-Za-z0-9._~:/@()+, -]+$/;
+
+  if (!pathPattern.test(normalized)) {
+    throw new Error(`Invalid Readarr root folder path: ${value}`);
+  }
+
+  const normalizedPath = path.posix.normalize(normalized);
+
+  if (normalizedPath === '.' || normalizedPath.includes('/../')) {
+    throw new Error(`Invalid Readarr root folder path: ${value}`);
+  }
+
+  return normalizedPath;
+};
+
 const deriveRootFolderPath = ({ book, author, rootFolders }) => {
   const direct = normalizeText(
     firstValue(book, [
@@ -2503,6 +2520,9 @@ const applyRebuildPayload = async ({ migrationDir, jobs }) => {
   };
 
   const resolveTargetIds = async (item, job, targetConfig) => {
+    const rootFolderPath = normalizeReadarrRootFolderPath(
+      item.addBook.rootFolderPath
+    );
     const qualityProfile = item.source.qualityProfileName
       ? targetConfig.qualityProfiles.find(
           (profile) =>
@@ -2527,7 +2547,7 @@ const applyRebuildPayload = async ({ migrationDir, jobs }) => {
     let rootFolder = targetConfig.rootFolders.find(
       (folder) =>
         normalizePathComparable(folder.path ?? folder.Path) ===
-        normalizePathComparable(item.addBook.rootFolderPath)
+        normalizePathComparable(rootFolderPath)
     );
     const missing = [];
 
@@ -2549,10 +2569,8 @@ const applyRebuildPayload = async ({ migrationDir, jobs }) => {
         apiKey: job.apiKey,
         endpoint: '/rootfolder',
         body: {
-          path: item.addBook.rootFolderPath,
-          name:
-            item.addBook.rootFolderPath.split('/').filter(Boolean).pop() ??
-            'Books',
+          path: rootFolderPath,
+          name: rootFolderPath.split('/').filter(Boolean).pop() ?? 'Books',
           defaultQualityProfileId: Number(
             qualityProfile.id ?? qualityProfile.Id
           ),
@@ -2567,7 +2585,6 @@ const applyRebuildPayload = async ({ migrationDir, jobs }) => {
         },
       });
       targetConfig.rootFolders.push(createdRootFolder);
-      rootFolder = createdRootFolder;
     }
 
     if (missing.length) {
@@ -2577,6 +2594,7 @@ const applyRebuildPayload = async ({ migrationDir, jobs }) => {
     return {
       qualityProfileId: Number(qualityProfile.id ?? qualityProfile.Id),
       metadataProfileId: Number(metadataProfile.id ?? metadataProfile.Id),
+      rootFolderPath,
     };
   };
 
@@ -2667,7 +2685,7 @@ const applyRebuildPayload = async ({ migrationDir, jobs }) => {
       tags,
       author: {
         ...local.author,
-        rootFolderPath: item.addBook.rootFolderPath,
+        rootFolderPath: targetIds.rootFolderPath,
         qualityProfileId: targetIds.qualityProfileId,
         metadataProfileId: targetIds.metadataProfileId,
         monitored: false,
@@ -2744,7 +2762,7 @@ const applyRebuildPayload = async ({ migrationDir, jobs }) => {
       ...lookupAuthor,
       qualityProfileId: targetIds.qualityProfileId,
       metadataProfileId: targetIds.metadataProfileId,
-      rootFolderPath: item.addBook.rootFolderPath,
+      rootFolderPath: targetIds.rootFolderPath,
       monitored: false,
       monitorNewItems: 'none',
       tags: [],
@@ -2828,7 +2846,7 @@ const applyRebuildPayload = async ({ migrationDir, jobs }) => {
           tags,
           author: {
             ...decision.result.author,
-            rootFolderPath: item.addBook.rootFolderPath,
+            rootFolderPath: targetIds.rootFolderPath,
             qualityProfileId: targetIds.qualityProfileId,
             metadataProfileId: targetIds.metadataProfileId,
             monitored: false,

deploy/compose.main.yml

@@ -14,8 +14,8 @@ services:
     healthcheck:
       test:
         [
-          "CMD-SHELL",
-          "node -e \"fetch('http://127.0.0.1:5055/api/v1/status').then((r)=>process.exit(r.ok?0:1)).catch(()=>process.exit(1))\"",
+          'CMD-SHELL',
+          'node -e "fetch(''http://127.0.0.1:5055/api/v1/status'').then((r)=>process.exit(r.ok?0:1)).catch(()=>process.exit(1))"',
         ]
       interval: 10s
       timeout: 5s

deploy/compose.readonly-local.yml

@@ -10,10 +10,10 @@ services:
       TZ: ${TZ:-America/Regina}
       PORT: 5055
       CONFIG_DIRECTORY: /app/config
-      SEERR_EXTERNAL_READ_ONLY: "true"
-      SEERR_ALLOW_PRODUCTION_EXTERNAL_READ_ONLY: "true"
+      SEERR_EXTERNAL_READ_ONLY: 'true'
+      SEERR_ALLOW_PRODUCTION_EXTERNAL_READ_ONLY: 'true'
       LOG_LEVEL: ${LOG_LEVEL:-info}
     ports:
-      - "${SEERRNG_PORT:-5055}:5055"
+      - '${SEERRNG_PORT:-5055}:5055'
     volumes:
       - ${SEERRNG_CONFIG_DIR:-../config}:/app/config

deploy/compose.readonly-swap.yml

@@ -7,10 +7,10 @@ services:
       TZ: ${TZ:-America/Regina}
       PORT: 5055
       CONFIG_DIRECTORY: /app/config
-      SEERR_EXTERNAL_READ_ONLY: "true"
-      SEERR_ALLOW_PRODUCTION_EXTERNAL_READ_ONLY: "true"
+      SEERR_EXTERNAL_READ_ONLY: 'true'
+      SEERR_ALLOW_PRODUCTION_EXTERNAL_READ_ONLY: 'true'
       LOG_LEVEL: ${LOG_LEVEL:-info}
     ports:
-      - "${SEERRNG_PORT:-5055}:5055"
+      - '${SEERRNG_PORT:-5055}:5055'
     volumes:
       - ${SEERRNG_CONFIG_DIR:-./config}:/app/config

package.json

@@ -20,8 +20,8 @@
     "migration:generate": "ts-node -r tsconfig-paths/register --project server/tsconfig.json ./node_modules/typeorm/cli.js migration:generate -d server/datasource.ts",
     "migration:create": "ts-node -r tsconfig-paths/register --project server/tsconfig.json ./node_modules/typeorm/cli.js migration:create -d server/datasource.ts",
     "migration:run": "ts-node -r tsconfig-paths/register --project server/tsconfig.json ./node_modules/typeorm/cli.js migration:run -d server/datasource.ts",
-    "format": "prettier --log-level warn --write --cache .",
-    "format:check": "prettier --check --cache .",
+    "format": "git ls-files -z | xargs -0 prettier --log-level warn --write --cache --ignore-unknown",
+    "format:check": "git ls-files -z | xargs -0 prettier --check --cache --ignore-unknown",
     "typecheck": "pnpm typecheck:server && pnpm typecheck:client",
     "typecheck:server": "tsc --project server/tsconfig.json --noEmit",
     "typecheck:client": "next typegen && tsc --noEmit",
@@ -85,6 +85,7 @@
     "openpgp": "6.3.0",
     "pg": "8.20.0",
     "pug": "3.0.4",
+    "qs": "6.15.2",
     "react": "19.2.6",
     "react-ace": "14.0.1",
     "react-animate-height": "3.2.3",
@@ -236,7 +237,7 @@
       "nodemailer": "8.0.5",
       "picomatch": "2.3.2",
       "postcss": "8.5.10",
-      "qs": "6.14.2",
+      "qs": "6.15.2",
       "systeminformation": "5.31.6",
       "tar": "7.5.15",
       "tmp": "0.2.4",

server/api/externalapi.ts

@@ -2,8 +2,8 @@ import { requestInterceptorFunction } from '@server/utils/customProxyAgent';
 import type { AxiosInstance, AxiosRequestConfig } from 'axios';
 import axios from 'axios';
 import rateLimit from 'axios-rate-limit';
-import { createHash } from 'node:crypto';
 import type NodeCache from 'node-cache';
+import { createHash } from 'node:crypto';
 
 // 5 minute default TTL (in seconds)
 const DEFAULT_TTL = 300;