Add all-day events, jump-to-today, event editing and ICS escaping#12
Open
UncleJ4ck wants to merge 1 commit into
Open
Add all-day events, jump-to-today, event editing and ICS escaping#12UncleJ4ck wants to merge 1 commit into
UncleJ4ck wants to merge 1 commit into
Conversation
- All-day events: model flag, date-only DTSTART parsing, VALUE=DATE save, an all-day toggle in the add/edit dialog, and All day rendering on cards - Jump-to-today button in the header for month and week views - Edit non-recurring manual events through the existing dialog - Escape SUMMARY/LOCATION/DESCRIPTION when saving manual events and unescape on parse, fixing data loss on reload for multi-line or comma/semicolon text - Replace the placeholder widget test with unit tests for the ICS text helpers
UncleJ4ck
force-pushed
the
events-recurrence-allday
branch
from
June 15, 2026 00:18
2499ba6 to
35f5c6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets the current
main(the multi-file rewrite). I checked what the rewrite already has and only added what was missing.Already in
main, so not touched: recurrence (includingYEARLY,BYDAY,EXDATE), theme persistence viasettings.json, and delete-single-occurrence.New
allDayfield toCalendarEvent. The parser detects a date-onlyDTSTART, the writer emitsDTSTART;VALUE=DATE, the add/edit dialog has anAll daytoggle, and cards showAll dayinstead of a time range.Fix
_saveManualEventsToDiskwroteSUMMARY/LOCATION/DESCRIPTIONraw. A multi-line description (the dialog allows 3 lines) wrote a real line break that the reader dropped on reload, losing everything after the first line.,;\were also unsafe. Added RFC 5545 text escaping on write and unescaping on read (SUMMARY/LOCATIONare now unescaped too, which helps imported calendars).Tests
test/widget_test.dartwas the placeholder template referencing a non-existent package and class, so it did not compile. Replaced it with unit tests for the ICS escape round-trip and date-only detection.Verification
flutter analyze: no new errors or warnings.flutter test: passes.flutter build linux --debug: builds, launched and rendered on a Wayland session (today button visible).Notes
DTENDdates for internal round-trip simplicity._sameEvent) are left untouched to keep this focused.