Expose currently hidden isWhitespace from xml-conduit#149
Open
tolysz wants to merge 1 commit intosnoyberg:masterfrom
Open
Expose currently hidden isWhitespace from xml-conduit#149tolysz wants to merge 1 commit intosnoyberg:masterfrom
tolysz wants to merge 1 commit intosnoyberg:masterfrom
Conversation
Collaborator
|
One of the builds fails, for some unrelated reason. I'll have a look at it. |
Collaborator
|
CI build should be fixed now, but your change must be rebased first. Also, now that I think about it, I am not in favor of exporting
IMHO, this is one of the very few cases where duplicating the function in your project is a better tradeoff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function is useful outside the module itself. It would be beneficial to expose it.