Open
Conversation
Owner
|
Hi there, First, thank you for contributing! I really appreciate your efforts into it. However, I do notice you have been experiencing issues getting the tests to work implementing this PR. Do you think it would be better to raise an issue with what you are encountering, and we can work out the details. Or would you like me to review this PR now? |
|
@sntran Seems like the tests for this one are now passing. Any chance we could get this one merged? |
Owner
|
Hi @nbw . With the lack of communication from @ReneKl , it's hard for me to figure out what this PR does. I have spent some time looking through the changes, and here are a few concerns I have:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make url configurable for api-tests with bypass lib,
timezone tests could not be fixed (also in doctest)