-
Notifications
You must be signed in to change notification settings - Fork 671
feat: add uv support to sbom command #6468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
772fbde to
abf5004
Compare
b97a18e to
cbef593
Compare
cbef593 to
eef6ff6
Compare
test/acceptance/fake-server.ts
Outdated
| .send(`{"errors":[{"title":"Bad Request","detail":"invalid SBOM"}]}`); | ||
| } | ||
|
|
||
| if (req.params.orgId === '55555555-5555-5555-5555-555555555555') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: In your tests you can set the response instead of hardcoding it in the fakeserver, for example take a look at setEndpointResponse()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I didn't know that was possible - done
| SNYK_API: 'http://localhost:' + port + baseApi, | ||
| SNYK_HOST: 'http://localhost:' + port, | ||
| SNYK_TOKEN: '123456789', | ||
| SNYK_DISABLE_ANALYTICS: '1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Ensure to set SNYK_HTTP_PROTOCOL_UPGRADE=0 to avoid issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
PeterSchafer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with minor improvement suggestions.
3a09f2d to
1d0af42
Compare
1d0af42 to
e82c7a0
Compare
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
This PR adds uv support to
snyk sbom. Note that this feature is not yet in Closed Beta, and requires a feature flag to be enabled.How should this be manually tested?
Turn on the
enableUvCLIfeature flag, and then build the CLI on this branch. Then run<path/to/local/cli> sbom, optionally with--all-projects. If there is auv.lockpresent, you should see an SBOM generated as expected for that uv project.What's the product update that needs to be communicated to CLI users?
None