chore: fix UFM transitive upgrades being marked as directly upgradable#6717
Draft
CatalinSnyk wants to merge 1 commit intomainfrom
Draft
chore: fix UFM transitive upgrades being marked as directly upgradable#6717CatalinSnyk wants to merge 1 commit intomainfrom
CatalinSnyk wants to merge 1 commit intomainfrom
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
In certain cases the Remediation Summary from the UFM Presenter would treat transitive dependency upgrades as directly upgradable. This would results in incorrect upgrade advice (e.g. Upgrade from x@1.2.3 to x@1.2.3 - since the actual upgrade would be inside for a nested dependency).
Where should the reviewer start?
How should this be manually tested?
--reachabilityenabled should show some different results in terms of issues reported as directly upgradable. The changes should also align more the UFM remediation output to the legacy CLI output (can be teste with OSS scans with/without reachability enabled).What's the product update that needs to be communicated to CLI users?
None.