Fix: Allow inline comments in .driftignore (#1688)#1741
Open
Mallikarjunadevops wants to merge 1 commit intosnyk:mainfrom
Open
Fix: Allow inline comments in .driftignore (#1688)#1741Mallikarjunadevops wants to merge 1 commit intosnyk:mainfrom
Mallikarjunadevops wants to merge 1 commit intosnyk:mainfrom
Conversation
This patch adds deterministic # indexing processing to strip inline comments prior to validating block depth. Evaluates inline constraints accurately without corrupting matched strings. Signed-off-by: Mallikarjunadevops <mallikarjunadevops@example.com>
|
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1688
Description
This Pull Request fixes the
.driftignoreparsing engine ignoring inline comments and corrupting trailing strings.Context
Currently, if a user writes
aws_iam_role.baz # created manually,driftctldoes not strip the comment unless the line strictly starts with#. This leads to the entire identifier tracking the comment block and silently failing to ignore the resource.Verification
#limits during line iterations.pkg/filter/testdatablock to forcefully vet the inline regex stripping.