Fix: Universal fallback for global Unsupported Schema Attribute panics (#1683, #1682)#1742
Open
Mallikarjunadevops wants to merge 2 commits intosnyk:mainfrom
Open
Conversation
This patch adds deterministic # indexing processing to strip inline comments prior to validating block depth. Evaluates inline constraints accurately without corrupting matched strings. Signed-off-by: Mallikarjunadevops <mallikarjunadevops@example.com>
…tion (snyk#1683, snyk#1682) This introduces an explicit generic interception block directly inside `convertInstance`. When modern remote Terraform Provider state files contain newly introduced attributes that driftctl schemas natively do not yet embed, `cty` currently initiates a recursive path panic causing the CLI to abort. By automatically converting the JSON streams to maps, iterating key comparisons directly against `cty.Type.AttributeTypes()`, and proactively dropping attributes that the target schema completely lacks structure for, driftctl universally becomes immune to future provider drift bugs without requiring immediate schema regeneration injections! Signed-off-by: Mallikarjunadevops <mallikarjunadevops@example.com> Signed-off-by: Mallikarjuna <muchu.mallikarjunarpa@gmail.com>
|
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1683, Fixes #1682
Description
This Pull Request permanently addresses systemic deserialization panics occurring whenever remote Terraform configuration instances populate new underlying elements (like
blue_green_update) that the static driftctl binary lacks embedded schema caching for.Context
Currently,
ctystrictly throws a fatalPathErrorwhen evaluating elements outside the localized schema bindings structure. AlthoughconvertInstancecatches this error locally to attempt safe casting, it currently feeds the exact same unpruned attributes back toctyconvert.Convertnatively natively resulting in the exact same crash.Verification
cty.Type.AttributeTypes()mappings.