Skip to content

Install default SIGINT handler#459

Closed
samuel-williams-shopify wants to merge 1 commit into
mainfrom
install-default-sigint-handler
Closed

Install default SIGINT handler#459
samuel-williams-shopify wants to merge 1 commit into
mainfrom
install-default-sigint-handler

Conversation

@samuel-williams-shopify

@samuel-williams-shopify samuel-williams-shopify commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a small Async::SIGINT compatibility shim loaded by require "async".
  • Install the shim only on affected CRuby versions and only when SIGINT is still using the default handler.
  • Add subprocess coverage for version gating, preserving existing handlers, and deferring SIGINT with Thread.handle_interrupt.

Testing

  • bundle exec sus test/async.rb --verbose
  • bundle exec rubocop -A lib/async.rb lib/async/sigint.rb test/async.rb
  • bundle exec bake decode:index:coverage lib
  • bundle exec sus

@samuel-williams-shopify samuel-williams-shopify force-pushed the install-default-sigint-handler branch from 824c5e8 to 04979d0 Compare June 29, 2026 01:14
@samuel-williams-shopify

Copy link
Copy Markdown
Contributor Author

I think fixing this upstream is a better idea.

@samuel-williams-shopify samuel-williams-shopify deleted the install-default-sigint-handler branch June 29, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant